Skip to content

Commit 04cbb11

Browse files
committed
Update advanced / standard vocab
1 parent c35a8fe commit 04cbb11

File tree

2 files changed

+49
-10
lines changed

2 files changed

+49
-10
lines changed

frontend/src/pages/clusterSettings/ModelServingPlatformSettings.tsx

Lines changed: 39 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,12 @@ import {
88
Flex,
99
FlexItem,
1010
FormGroup,
11+
Icon,
12+
Popover,
1113
Stack,
1214
StackItem,
1315
} from '@patternfly/react-core';
16+
import { OutlinedQuestionCircleIcon } from '@patternfly/react-icons';
1417
import SettingSection from '#~/components/SettingSection';
1518
import SimpleSelect, { SimpleSelectOption } from '#~/components/SimpleSelect';
1619
import { ModelServingPlatformEnabled } from '#~/types';
@@ -77,12 +80,12 @@ const ModelServingPlatformSettings: React.FC<ModelServingPlatformSettingsProps>
7780
const options: SimpleSelectOption[] = [
7881
{
7982
key: DeploymentMode.RawDeployment,
80-
label: 'Standard (No additional dependencies)',
83+
label: 'KServe RawDeployment',
8184
isDisabled: !allowedToPatchDSC,
8285
},
8386
{
8487
key: DeploymentMode.Serverless,
85-
label: 'Advanced (Serverless and Service Mesh)',
88+
label: 'Knative Serverless',
8689
isDisabled: !isServerlessAvailable || !allowedToPatchDSC,
8790
},
8891
];
@@ -147,7 +150,40 @@ const ModelServingPlatformSettings: React.FC<ModelServingPlatformSettingsProps>
147150
fieldId="default-deployment-mode-select"
148151
label="Default deployment mode"
149152
labelHelp={
150-
<DashboardHelpTooltip content="Deployment modes define which technology stack will be used to deploy a model, offering different levels of management and scalability. The default deployment mode will be automatically selected during deployment." />
153+
<Popover
154+
bodyContent={
155+
<>
156+
<div>
157+
The selected deployment mode determines how the model server runs in
158+
your environment. The default deployment mode will be automatically
159+
selected for users during deployment.
160+
</div>
161+
<ul
162+
style={{
163+
listStyleType: 'disc',
164+
paddingLeft: '1.5rem',
165+
marginTop: '0.5rem',
166+
marginBottom: 0,
167+
}}
168+
>
169+
<li>
170+
<strong>Knative Serverless</strong>: Autoscale to and from zero based
171+
on request volume with minimal customization. Recommended for most
172+
workloads.
173+
</li>
174+
<li>
175+
<strong>KServe RawDeployment</strong>: Always running with no
176+
autoscaling. Use for custom serving setups or if your model needs to
177+
stay active.
178+
</li>
179+
</ul>
180+
</>
181+
}
182+
>
183+
<Icon aria-label="Deployment mode info" role="button">
184+
<OutlinedQuestionCircleIcon />
185+
</Icon>
186+
</Popover>
151187
}
152188
>
153189
<SimpleSelect

frontend/src/pages/modelServing/screens/projects/kServeModal/KServeDeploymentModeDropdown.tsx

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ type Props = {
1313
export const KServeDeploymentModeDropdown: React.FC<Props> = ({ isRaw, setIsRaw, isDisabled }) => {
1414
const options: SimpleSelectOption[] = [
1515
{
16-
label: `Standard`,
16+
label: `KServe RawDeployment`,
1717
key: DeploymentMode.RawDeployment,
1818
},
1919
{
20-
label: `Advanced`,
20+
label: `Knative Serverless`,
2121
key: DeploymentMode.Serverless,
2222
},
2323
];
@@ -31,7 +31,10 @@ export const KServeDeploymentModeDropdown: React.FC<Props> = ({ isRaw, setIsRaw,
3131
<Popover
3232
bodyContent={
3333
<>
34-
<div>Deployment modes determine the technology used to deploy your model:</div>
34+
<div>
35+
The selected deployment mode determines how the model server runs in your
36+
environment.
37+
</div>
3538
<ul
3639
style={{
3740
listStyleType: 'disc',
@@ -41,12 +44,12 @@ export const KServeDeploymentModeDropdown: React.FC<Props> = ({ isRaw, setIsRaw,
4144
}}
4245
>
4346
<li>
44-
<strong>Advanced</strong>: Uses Knative Serverless but requires some manual
45-
customization. Supports autoscaling.
47+
<strong>Knative Serverless</strong>: Autoscale to and from zero based on request
48+
volume with minimal customization. Recommended for most workloads.
4649
</li>
4750
<li>
48-
<strong>Standard</strong>: Uses Kubernetes resources with fewer dependencies and a
49-
simpler setup. Does not support autoscaling.
51+
<strong>KServe RawDeployment</strong>: Always running with no autoscaling. Use for
52+
custom serving setups or if your model needs to stay active.
5053
</li>
5154
</ul>
5255
</>

0 commit comments

Comments
 (0)