Skip to content

Commit 2a4825f

Browse files
committed
Add reosurce character limit to ALL model deployments
1 parent 46e1092 commit 2a4825f

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

frontend/src/pages/modelServing/screens/projects/kServeModal/ManageKServeModal.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,10 @@ import { ConnectionSection } from '#~/pages/modelServing/screens/projects/Infere
5151
import K8sNameDescriptionField, {
5252
useK8sNameDescriptionFieldData,
5353
} from '#~/concepts/k8s/K8sNameDescriptionField/K8sNameDescriptionField';
54-
import { isK8sNameDescriptionDataValid } from '#~/concepts/k8s/K8sNameDescriptionField/utils';
54+
import {
55+
isK8sNameDescriptionDataValid,
56+
LimitNameResourceType,
57+
} from '#~/concepts/k8s/K8sNameDescriptionField/utils';
5558
import { useProfileIdentifiers } from '#~/concepts/hardwareProfiles/utils';
5659
import usePrefillModelDeployModal, {
5760
ModelDeployPrefillInfo,
@@ -124,6 +127,7 @@ const ManageKServeModal: React.FC<ManageKServeModalProps> = ({
124127

125128
const { data: kServeNameDesc, onDataChange: setKserveNameDesc } = useK8sNameDescriptionFieldData({
126129
initialData: editInfo?.inferenceServiceEditInfo,
130+
limitNameResourceType: LimitNameResourceType.MODEL_DEPLOYMENT,
127131
});
128132

129133
const [connection, setConnection] = React.useState<Connection>();

packages/model-serving/src/components/deploymentWizard/useDeploymentWizard.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { useK8sNameDescriptionFieldData } from '@odh-dashboard/internal/concepts
44
import {
55
extractK8sNameDescriptionFieldData,
66
LimitNameResourceType,
7-
resourceTypeLimits,
87
} from '@odh-dashboard/internal/concepts/k8s/K8sNameDescriptionField/utils';
98
import { useModelFormatField } from './fields/ModelFormatField';
109
import { useModelTypeField } from './fields/ModelTypeSelectField';
@@ -60,15 +59,10 @@ export const useModelDeploymentWizard = (
6059
}, [modelLocationData.connectionTypesLoaded, modelLocationData.isLoadingSecretData]);
6160

6261
// Step 2: Model Deployment
63-
const limitNameResourceType =
64-
initialData?.k8sNameDesc?.k8sName.state.maxLength ===
65-
resourceTypeLimits[LimitNameResourceType.MODEL_DEPLOYMENT]
66-
? LimitNameResourceType.MODEL_DEPLOYMENT
67-
: undefined;
6862
const k8sNameDesc = useK8sNameDescriptionFieldData({
6963
initialData: extractK8sNameDescriptionFieldData(initialData?.k8sNameDesc),
7064
editableK8sName: !initialData?.k8sNameDesc?.k8sName.state.immutable,
71-
limitNameResourceType,
65+
limitNameResourceType: LimitNameResourceType.MODEL_DEPLOYMENT,
7266
});
7367
const hardwareProfileConfig = useHardwareProfileConfig(...(initialData?.hardwareProfile ?? []));
7468
const modelFormatState = useModelFormatField(

0 commit comments

Comments
 (0)