Update to be just the yaml change

Author: ashley-o0o

frontend/src/concepts/connectionTypes/utils.ts

@@ -333,28 +333,9 @@ export const assembleConnectionSecret = (
     [key: string]: ConnectionTypeValueType;
   },
 ): Connection => {
-  const isOCI =
-    connectionTypeName ===
-    modelServingCompatibleTypesMetadata[ModelServingCompatibleTypes.OCI].resource;
-  const valuesWithDefaults = isOCI
-    ? {
-        ...values,
-        '.dockerconfigjson': values['.dockerconfigjson'] ?? '',
-        OCI_HOST: values.OCI_HOST ?? '',
-      }
-    : values;
-
   const connectionValuesAsStrings = Object.fromEntries(
-    Object.entries(valuesWithDefaults)
+    Object.entries(values)
       .map(([key, value]) => {
-        // For OCI connections, convert empty .dockerconfigjson and OCI_HOST to '{}'
-        if (
-          isOCI &&
-          (key === '.dockerconfigjson' || key === 'OCI_HOST') &&
-          (!value || value === '')
-        ) {
-          return [key, '{}'];
-        }
         if (Array.isArray(value)) {
           return [key, JSON.stringify(value)]; // multi select
         }
@@ -396,22 +377,13 @@ export const parseConnectionSecretValues = (
   connectionType?: ConnectionTypeConfigMapObj,
 ): { [key: string]: ConnectionTypeValueType } => {
   const response: { [key: string]: ConnectionTypeValueType } = {};
-  const isOCI = connectionType
-    ? isModelServingCompatible(connectionType, ModelServingCompatibleTypes.OCI)
-    : false;
 
   for (const [key, value] of Object.entries(connection.data ?? {})) {
     const decodedString = window.atob(value);
     const matchingField = connectionType?.data?.fields?.find(
       (f) => isConnectionTypeDataField(f) && f.envVar === key,
     );
 
-    // For OCI connections, convert '{}' back to empty string for display in edit forms
-    if (isOCI && (key === '.dockerconfigjson' || key === 'OCI_HOST') && decodedString === '{}') {
-      response[key] = '';
-      continue;
-    }
-
     if (matchingField?.type === ConnectionTypeFieldType.Boolean) {
       response[key] = decodedString === 'true';
     } else if (matchingField?.type === ConnectionTypeFieldType.Numeric) {

frontend/src/pages/modelServing/screens/projects/InferenceServiceModal/__tests__/ConnectionSection.spec.tsx

@@ -313,9 +313,7 @@ describe('ConnectionsFormSection', () => {
           },
         },
         stringData: {
-          '.dockerconfigjson': '{}',
           ACCESS_TYPE: '["Push"]',
-          OCI_HOST: '{}',
         },
       }),
     );

packages/model-serving/src/components/deploymentWizard/fields/ModelLocationInputFields.tsx

@@ -230,21 +230,7 @@ const hasRequiredConnectionTypeFields = (modelLocationData: ModelLocationData):
       (field): field is ConnectionTypeDataField => 'envVar' in field && 'required' in field,
     ) || [];
 
-  const isOCI = isModelServingCompatible(
-    modelLocationData.connectionTypeObject,
-    ModelServingCompatibleTypes.OCI,
-  );
-
-  const requiredFields = dataFields
-    .filter((field) => {
-      if (!field.required) return false;
-      if (isOCI && (field.envVar === '.dockerconfigjson' || field.envVar === 'OCI_HOST')) {
-        return false;
-      }
-      return true;
-    })
-    .map((field) => field.envVar);
-
+  const requiredFields = dataFields.filter((field) => field.required).map((field) => field.envVar);
   if (
     isModelServingCompatible(
       modelLocationData.connectionTypeObject,

packages/model-serving/src/components/deploymentWizard/fields/modelLocationFields/ExistingConnectionField.tsx

@@ -14,7 +14,6 @@ import {
   getConnectionTypeRef,
   isModelServingCompatible,
   ModelServingCompatibleTypes,
-  parseConnectionSecretValues,
 } from '@odh-dashboard/internal/concepts/connectionTypes/utils';
 import {
   Connection,
@@ -112,7 +111,6 @@ export const ExistingConnectionField: React.FC<ExistingConnectionFieldProps> = (
 
               if (newConnectionType) {
                 const additionalFields: { modelPath?: string; modelUri?: string } = {};
-                const fieldValues = parseConnectionSecretValues(newConnection, newConnectionType);
 
                 if (
                   isModelServingCompatible(
@@ -135,7 +133,7 @@ export const ExistingConnectionField: React.FC<ExistingConnectionFieldProps> = (
                   type: ModelLocationType.EXISTING,
                   connectionTypeObject: newConnectionType,
                   connection: getResourceNameFromK8sResource(newConnection),
-                  fieldValues,
+                  fieldValues: {},
                   additionalFields,
                 });
               }
@@ -182,11 +180,7 @@ export const ExistingConnectionField: React.FC<ExistingConnectionFieldProps> = (
           selectedConnectionType?.metadata.name === ConnectionTypeRefs.OCI) && (
           <StackItem>
             <ConnectionOciPathField
-              ociHost={
-                isExistingModelLocation(modelLocationData)
-                  ? String(modelLocationData.fieldValues.OCI_HOST ?? '')
-                  : window.atob(selectedConnection?.data?.OCI_HOST ?? '')
-              }
+              ociHost={window.atob(selectedConnection?.data?.OCI_HOST ?? '')}
               modelUri={
                 isExistingModelLocation(modelLocationData)
                   ? modelLocationData.additionalFields.modelUri ?? ''