Skip to content

Commit a57764a

Browse files
committed
Adjust for new footer
1 parent edf5253 commit a57764a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/model-serving/src/components/deploymentWizard/ModelDeploymentWizard.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,9 +141,10 @@ const ModelDeploymentWizard: React.FC<ModelDeploymentWizardProps> = ({
141141
clearError={() => setSubmitError(null)}
142142
isLoading={isLoading}
143143
submitButtonText={primaryButtonText}
144+
isAdvancedSettingsStepValid={validation.isAdvancedSettingsStepValid} //TODO: Remove this line once summary page is added
144145
/>
145146
),
146-
[submitError, isLoading, primaryButtonText],
147+
[submitError, isLoading, primaryButtonText, validation.isAdvancedSettingsStepValid], //TODO: Remove validation.isAdvancedSettingsStepValid once summary page is added
147148
);
148149

149150
return (
@@ -173,10 +174,6 @@ const ModelDeploymentWizard: React.FC<ModelDeploymentWizardProps> = ({
173174
<WizardStep
174175
name="Advanced settings (optional)"
175176
id="advanced-options-step"
176-
footer={{
177-
nextButtonText: primaryButtonText,
178-
isNextDisabled: !validation.isAdvancedSettingsStepValid,
179-
}} //TODO: Remove this footer when summary page is added
180177
isDisabled={!validation.isModelSourceStepValid || !validation.isModelDeploymentStepValid}
181178
>
182179
{wizardState.loaded.advancedOptionsLoaded ? (

packages/model-serving/src/components/generic/WizardFooterWithDisablingNext.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ type WizardFooterWithDisablingNextProps = {
1717
clearError?: () => void;
1818
isLoading?: boolean;
1919
submitButtonText?: string;
20+
isAdvancedSettingsStepValid?: boolean; //TODO: Remove line when summary page added
2021
};
2122

2223
// When clicking Next, the default WizardFooter will skip over disabled steps, but we want to prevent that and just disable the Next button
@@ -26,10 +27,12 @@ export const WizardFooterWithDisablingNext: React.FC<WizardFooterWithDisablingNe
2627
clearError,
2728
isLoading,
2829
submitButtonText = 'Deploy model',
30+
isAdvancedSettingsStepValid = true, //TODO: Remove line when summary page added
2931
}) => {
3032
const { activeStep, steps, goToNextStep, goToPrevStep, close } = useWizardContext();
3133

3234
const isFinalStep = activeStep.index === steps.length;
35+
const isNextDisabled = !isAdvancedSettingsStepValid; //TODO: Remove line when summary page added
3336

3437
return (
3538
<WizardFooterWrapper>
@@ -64,7 +67,7 @@ export const WizardFooterWithDisablingNext: React.FC<WizardFooterWithDisablingNe
6467
variant="primary"
6568
onClick={goToNextStep}
6669
isLoading={isLoading}
67-
isDisabled={isLoading || steps[activeStep.index]?.isDisabled}
70+
isDisabled={isLoading || steps[activeStep.index]?.isDisabled || isNextDisabled} //TODO: Remove isNextDisabled when summary page added
6871
>
6972
{isFinalStep ? submitButtonText : 'Next'}
7073
</Button>

0 commit comments

Comments
 (0)