Skip to content

Server should reject malformed messages #15

@ashn-dot-dev

Description

@ashn-dot-dev

As of commit de8d58c, message deserialization does zero error checking, and the server will safely crash if a malformed message come across the wire. Although this is not a huge issue in a just-for-fun game intended to be played between friends, it is worth cleaning up the code around message deserialization. Change instances of T::init_from_bubby into T::parse_from_bubby which will return std::result[[T, std::error]] instead of T.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions