Skip to content

Commit aba1122

Browse files
committed
Small refactor + add unit tests
1 parent 8721531 commit aba1122

File tree

57 files changed

+2566
-394
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+2566
-394
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,3 +136,4 @@ jobs:
136136
flutter test integration_test/rockets_screen_integration_test.dart --flavor dev
137137
flutter test integration_test/rocket_screen_test.dart --flavor dev
138138
flutter test integration_test/rockets_integration_live_test.dart --flavor dev
139+
flutter test integration_test/roadster_detail_integration_test.dart --flavor dev

lib/data/network/data_source/roadster_network_data_source.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import 'package:dio/dio.dart';
12
import 'package:flutter_bloc_app_template/data/network/api_result.dart';
23
import 'package:flutter_bloc_app_template/data/network/model/roadster/network_roadster_model.dart';
34
import 'package:flutter_bloc_app_template/data/network/service/roadster/roadster_service.dart';
@@ -16,6 +17,8 @@ class RoadsterNetworkDataSource implements RoadsterDataSource {
1617
try {
1718
final result = await _service.fetchRoadster();
1819
return ApiResult.success(result);
20+
} on DioException catch (e) {
21+
return ApiResult.error(e.message ?? e.toString());
1922
} catch (e) {
2023
return Future.value(ApiResult.error(e.toString()));
2124
}
Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
1-
class Mission {
1+
import 'package:equatable/equatable.dart';
2+
3+
class Mission extends Equatable {
24
Mission({required this.name, required this.isPrimary});
35

46
final String name;
57
final bool isPrimary;
8+
9+
@override
10+
List<Object?> get props => [name, isPrimary];
611
}
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,13 @@
1+
import 'package:equatable/equatable.dart';
12
import 'package:flutter/material.dart';
23

3-
class OrbitalData {
4+
class OrbitalData extends Equatable {
45
OrbitalData({required this.label, required this.value, required this.icon});
56

67
final String label;
78
final String value;
89
final IconData icon;
10+
11+
@override
12+
List<Object?> get props => [label, value, icon];
913
}

0 commit comments

Comments
 (0)