Code quality improvement (pytorch#3241)

aliafzal · facebook-github-bot · commit ea29cf6bf0cf · 2025-07-30T20:06:48.000-07:00
Summary: Pull Request resolved: pytorch#3241 removing outdated todo Reviewed By: SSYernar Differential Revision: D79148195 fbshipit-source-id: c9b294abc3353e464b81a2354e952311216bf5c3
diff --git a/torchrec/metrics/segmented_ne.py b/torchrec/metrics/segmented_ne.py
@@ -176,7 +176,7 @@ class SegmentedNEMetricComputation(RecMetricComputation):
     def __init__(
         self,
         *args: Any,
-        include_logloss: bool = False,  # TODO - include
+        include_logloss: bool = False,
         num_groups: int = 1,
         grouping_keys: str = "grouping_keys",
         cast_keys_to_int: bool = False,
diff --git a/torchrec/sparse/tests/test_jagged_tensor.py b/torchrec/sparse/tests/test_jagged_tensor.py
@@ -548,7 +548,6 @@ def test_length_vs_offset(self) -> None:
         )
 
         self.assertTrue(torch.equal(j_offset.lengths(), j_lens.lengths()))
-        # TODO: T88149179
         self.assertTrue(torch.equal(j_offset.offsets(), j_lens.offsets().int()))
 
         stride_per_key_per_rank = [[3], [5]]

Original file line number	Diff line number	Diff line change
`@@ -548,7 +548,6 @@ def test_length_vs_offset(self) -> None:`
`548`	`548`	`)`
`549`	`549`
`550`	`550`	`self.assertTrue(torch.equal(j_offset.lengths(), j_lens.lengths()))`
`551`		`- # TODO: T88149179`
`552`	`551`	`self.assertTrue(torch.equal(j_offset.offsets(), j_lens.offsets().int()))`
`553`	`552`
`554`	`553`	`stride_per_key_per_rank = [[3], [5]]`