Skip to content

Commit 05f17a6

Browse files
committed
Fix: Report error codes in tests
1 parent b175103 commit 05f17a6

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

scripts/test_stringcuzilla.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ namespace sz = ashvardanian::stringzilla;
3535
int main(int argc, char const **argv) {
3636
sz_unused(argc && argv);
3737
std::printf("Hi, dear tester! You look nice today!\n");
38-
sz::scripts::log_environment();
38+
if (auto code = sz::scripts::log_environment(); code != 0) return code;
3939

4040
sz::scripts::test_similarity_scores_equivalence();
4141
sz::scripts::test_similarity_scores_memory_usage();

scripts/test_stringcuzilla.cu

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,14 @@
3131
#include "test_stringcuzilla.cuh"
3232

3333
namespace sz = ashvardanian::stringzilla;
34-
using namespace sz::scripts;
3534

3635
int main(int argc, char const **argv) {
3736
sz_unused(argc && argv);
3837
std::printf("Hi, dear tester! You look nice today!\n");
39-
scripts::log_environment();
38+
if (auto code = sz::scripts::log_environment(); code != 0) return code;
4039

41-
scripts::test_similarity_scores_equivalence();
42-
scripts::test_similarity_scores_memory_usage();
40+
sz::scripts::test_similarity_scores_equivalence();
41+
sz::scripts::test_similarity_scores_memory_usage();
4342

4443
std::printf("All tests passed... Unbelievable!\n");
4544
return 0;

scripts/test_stringcuzilla.cuh

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ namespace ashvardanian {
2121
namespace stringzilla {
2222
namespace scripts {
2323

24-
void log_environment() {
24+
int log_environment() {
2525
std::printf("- Uses Haswell: %s \n", SZ_USE_HASWELL ? "yes" : "no");
2626
std::printf("- Uses Skylake: %s \n", SZ_USE_SKYLAKE ? "yes" : "no");
2727
std::printf("- Uses Ice Lake: %s \n", SZ_USE_ICE ? "yes" : "no");
@@ -57,6 +57,7 @@ void log_environment() {
5757
std::printf("- CUDA managed memory support: %s\n", prop.managedMemory == 1 ? "yes" : "no");
5858
std::printf("- CUDA unified memory support: %s\n", prop.unifiedAddressing == 1 ? "yes" : "no");
5959
#endif
60+
return 0;
6061
}
6162

6263
/**
@@ -527,15 +528,15 @@ void test_similarity_scores_memory_usage() {
527528
experiment.batch_size, experiment.min_string_length, experiment.max_string_length,
528529
experiment.iterations);
529530

530-
// Single-threaded serial Levenshtein distance implementation
531-
test_similarity_scores_fuzzy<sz_size_t>( //
532-
levenshtein_baselines_t {}, //
533-
levenshtein_distances<sz_cap_serial_k, char, std::allocator<char>> {}, experiment);
534-
535-
// Multi-threaded parallel Levenshtein distance implementation
531+
// Multi-threaded serial Levenshtein distance implementation
536532
test_similarity_scores_fuzzy<sz_size_t>( //
537533
levenshtein_baselines_t {}, //
538534
levenshtein_distances<sz_cap_parallel_k, char, std::allocator<char>> {}, experiment);
535+
536+
// CUDA Levenshtein distance against Multi-threaded on CPU
537+
test_similarity_scores_fuzzy<sz_size_t>( //
538+
levenshtein_distances<sz_cap_parallel_k, char, std::allocator<char>> {}, //
539+
levenshtein_distances<sz_cap_cuda_k, char, std::allocator<char>> {}, experiment);
539540
}
540541
}
541542

0 commit comments

Comments
 (0)