Skip to content

Commit dededf7

Browse files
authored
Disable failing array_union edge-case with nested null array (apache#19904)
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Part of apache#19798 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> This is an edge case, would prefer to fix upstream in arrow-rs instead of having handling code here, so just disable test for now. - arrow-rs issue: apache/arrow-rs#9227 ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Disable edge-case array_union SLT ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Test related change ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> No. <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
1 parent 84e1ccc commit dededf7

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

datafusion/sqllogictest/test_files/array.slt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4747,10 +4747,11 @@ select array_union(arrow_cast([], 'LargeList(Int64)'), arrow_cast([], 'LargeList
47474747
[]
47484748

47494749
# array_union scalar function #7
4750-
query ?
4751-
select array_union([[null]], []);
4752-
----
4753-
[[]]
4750+
# re-enable when https://github.com/apache/arrow-rs/issues/9227 is fixed
4751+
# query ?
4752+
# select array_union([[null]], []);
4753+
# ----
4754+
# [[]]
47544755

47554756
query error DataFusion error: Error during planning: Failed to coerce arguments to satisfy a call to 'array_union' function:
47564757
select array_union(arrow_cast([[null]], 'LargeList(List(Int64))'), arrow_cast([], 'LargeList(Int64)'));

0 commit comments

Comments
 (0)