Apply suggestions from code review

Co-authored-by: Sebastian Berg <[email protected]>

Author: czgdp1807

numpy/core/src/multiarray/conversion_utils.c

@@ -182,7 +182,7 @@ PyArray_CopyConverter(PyObject *obj, _PyArray_CopyMode *copymode) {
         }
 
         int_copymode = PyLong_AsLong(mode_value);
-        if (int_copymode < 0 || PyErr_Occurred()) {
+        if (error_converting(int_copymode)) {
             return NPY_FAIL;
         }
     }

numpy/core/src/multiarray/ctors.c

@@ -1747,7 +1747,7 @@ PyArray_FromAny(PyObject *op, PyArray_Descr *newtype, int min_depth,
 
     /* Create a new array and copy the data */
     Py_INCREF(dtype);  /* hold on in case of a subarray that is replaced */
-    if( flags & NPY_ARRAY_ENSURENOCOPY ) {
+    if (flags & NPY_ARRAY_ENSURENOCOPY ) {
         PyErr_SetString(PyExc_ValueError, 
                         "Unable to avoid copy while creating "
                         "an array from descriptor.");
@@ -1953,11 +1953,9 @@ PyArray_FromArray(PyArrayObject *arr, PyArray_Descr *newtype, int flags)
            !PyArray_EquivTypes(oldtype, newtype);
 
     if (copy) {
-
-        if( flags & NPY_ARRAY_ENSURENOCOPY ) {
+        if (flags & NPY_ARRAY_ENSURENOCOPY ) {
             PyErr_SetString(PyExc_ValueError,
-                            "Unable to avoid copy while creating "
-                            "an array from given array.");
+                    "Unable to avoid copy while creating an array from given array.");
             return NULL;
         }
 

numpy/core/src/multiarray/multiarraymodule.c

@@ -1622,7 +1622,8 @@ _array_fromobject_generic(
 
     if (copy == NPY_COPY_ALWAYS) {
         flags = NPY_ARRAY_ENSURECOPY;
-    } else if( copy == NPY_COPY_NEVER ) {
+    }
+    else if (copy == NPY_COPY_NEVER ) {
         flags = NPY_ARRAY_ENSURENOCOPY;
     }
     if (order == NPY_CORDER) {