Skip to content

Commit 96789b0

Browse files
committed
MAINT: Run CI tests even if linter fails.
1 parent 214bf57 commit 96789b0

File tree

2 files changed

+30
-30
lines changed

2 files changed

+30
-30
lines changed

.github/workflows/build_test.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
- uses: ./.github/actions
5353

5454
basic:
55-
needs: [smoke_test, lint]
55+
needs: [smoke_test]
5656
runs-on: ubuntu-latest
5757
strategy:
5858
matrix:
@@ -68,7 +68,7 @@ jobs:
6868
- uses: ./.github/actions
6969

7070
debug:
71-
needs: [smoke_test, lint]
71+
needs: [smoke_test]
7272
runs-on: ubuntu-20.04
7373
env:
7474
USE_DEBUG: 1
@@ -83,7 +83,7 @@ jobs:
8383
- uses: ./.github/actions
8484

8585
blas64:
86-
needs: [smoke_test, lint]
86+
needs: [smoke_test]
8787
runs-on: ubuntu-latest
8888
env:
8989
NPY_USE_BLAS_ILP64: 1
@@ -98,7 +98,7 @@ jobs:
9898
- uses: ./.github/actions
9999

100100
full:
101-
needs: [smoke_test, lint]
101+
needs: [smoke_test]
102102
runs-on: ubuntu-18.04
103103
env:
104104
USE_WHEEL: 1
@@ -116,7 +116,7 @@ jobs:
116116
- uses: ./.github/actions
117117

118118
benchmark:
119-
needs: [smoke_test, lint]
119+
needs: [smoke_test]
120120
runs-on: ubuntu-latest
121121
env:
122122
PYTHONOPTIMIZE: 2
@@ -137,7 +137,7 @@ jobs:
137137
- uses: ./.github/actions
138138

139139
no_relaxed_strides:
140-
needs: [smoke_test, lint]
140+
needs: [smoke_test]
141141
runs-on: ubuntu-latest
142142
env:
143143
NPY_RELAXED_STRIDES_CHECKING: 0
@@ -154,7 +154,7 @@ jobs:
154154
- uses: ./.github/actions
155155

156156
use_wheel:
157-
needs: [smoke_test, lint]
157+
needs: [smoke_test]
158158
runs-on: ubuntu-latest
159159
env:
160160
USE_WHEEL: 1
@@ -170,7 +170,7 @@ jobs:
170170
- uses: ./.github/actions
171171

172172
no_array_func:
173-
needs: [smoke_test, lint]
173+
needs: [smoke_test]
174174
runs-on: ubuntu-latest
175175
env:
176176
NUMPY_EXPERIMENTAL_ARRAY_FUNCTION: 0
@@ -185,7 +185,7 @@ jobs:
185185
- uses: ./.github/actions
186186

187187
no_openblas:
188-
needs: [smoke_test, lint]
188+
needs: [smoke_test]
189189
runs-on: ubuntu-latest
190190
env:
191191
BLAS: None
@@ -203,7 +203,7 @@ jobs:
203203
- uses: ./.github/actions
204204

205205
pypy37:
206-
needs: [smoke_test, lint]
206+
needs: [smoke_test]
207207
runs-on: ubuntu-latest
208208
steps:
209209
- uses: actions/checkout@v2
@@ -216,7 +216,7 @@ jobs:
216216
- uses: ./.github/actions
217217

218218
sdist:
219-
needs: [smoke_test, lint]
219+
needs: [smoke_test]
220220
runs-on: ubuntu-latest
221221
env:
222222
USE_SDIST: 1

azure-pipelines.yml

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,6 @@ stages:
1818
- stage: InitialTests
1919
jobs:
2020

21-
- job: Lint
22-
condition: and(succeeded(), eq(variables['Build.Reason'], 'PullRequest'))
23-
pool:
24-
vmImage: 'ubuntu-18.04'
25-
steps:
26-
- task: UsePythonVersion@0
27-
inputs:
28-
versionSpec: '3.8'
29-
addToPath: true
30-
architecture: 'x64'
31-
- script: >-
32-
python -m pip install -r linter_requirements.txt
33-
displayName: 'Install tools'
34-
# pip 21.1 emits a pile of garbage messages to annoy users :)
35-
# failOnStderr: true
36-
- script: |
37-
python tools/linter.py --branch origin/$(System.PullRequest.TargetBranch)
38-
displayName: 'Run Lint Checks'
39-
failOnStderr: true
4021
# Native build is based on gcc flag `-march=native`
4122
- job: Linux_baseline_native
4223
pool:
@@ -66,6 +47,25 @@ stages:
6647
- stage: ComprehensiveTests
6748
jobs:
6849

50+
- job: Lint
51+
condition: and(succeeded(), eq(variables['Build.Reason'], 'PullRequest'))
52+
pool:
53+
vmImage: 'ubuntu-18.04'
54+
steps:
55+
- task: UsePythonVersion@0
56+
inputs:
57+
versionSpec: '3.8'
58+
addToPath: true
59+
architecture: 'x64'
60+
- script: >-
61+
python -m pip install -r linter_requirements.txt
62+
displayName: 'Install tools'
63+
# pip 21.1 emits a pile of garbage messages to annoy users :)
64+
# failOnStderr: true
65+
- script: |
66+
python tools/linter.py --branch origin/$(System.PullRequest.TargetBranch)
67+
displayName: 'Run Lint Checks'
68+
failOnStderr: true
6969
7070
- job: WindowsFast
7171
pool:

0 commit comments

Comments
 (0)