MAINT: Remove unnecessary assert that may trip 32 bit

seberg · seberg · commit b2c2d1920cca · 2021-10-11T19:32:34.000-05:00
Mainly to see if this is indeed the problem, but the assert is
not necessary, and it might be we end up with the wrong dtype when
the input is a compatible (but different) integer already?
diff --git a/numpy/core/src/umath/ufunc_object.c b/numpy/core/src/umath/ufunc_object.c
@@ -3470,9 +3470,6 @@ PyUFunc_Reduceat(PyUFuncObject *ufunc, PyArrayObject *arr, PyArrayObject *ind,
     }
 
     if (need_outer_iterator) {
-        /* indices are already passed in correctly */
-        assert(PyArray_DESCR(op[2])->type_num == NPY_INTP);
-
         PyArray_Descr *op_dtypes[3] = {descrs[0], descrs[1], NULL};
 
         npy_uint32 flags = NPY_ITER_ZEROSIZE_OK|

Original file line number	Diff line number	Diff line change
`@@ -3470,9 +3470,6 @@ PyUFunc_Reduceat(PyUFuncObject ufunc, PyArrayObject arr, PyArrayObject *ind,`
`3470`	`3470`	`}`
`3471`	`3471`
`3472`	`3472`	`if (need_outer_iterator) {`
`3473`		`- /* indices are already passed in correctly */`
`3474`		`- assert(PyArray_DESCR(op[2])->type_num == NPY_INTP);`
`3475`		`-`
`3476`	`3473`	`PyArray_Descr *op_dtypes[3] = {descrs[0], descrs[1], NULL};`
`3477`	`3474`
`3478`	`3475`	`npy_uint32 flags = NPY_ITER_ZEROSIZE_OK\|`