Merge pull request numpy#19409 from defoishugo/fix_ufunc_object_leaks

mattip · web-flow · commit bdb5cc7b54d1 · 2021-07-06T08:38:08.000+03:00
BUG: fix some memory leaks in ufunc_object
diff --git a/numpy/core/src/umath/ufunc_object.c b/numpy/core/src/umath/ufunc_object.c
@@ -5228,6 +5228,7 @@ PyUFunc_RegisterLoopForDescr(PyUFuncObject *ufunc,
 
     arg_typenums = PyArray_malloc(ufunc->nargs * sizeof(int));
     if (arg_typenums == NULL) {
+        Py_DECREF(key);
         PyErr_NoMemory();
         return -1;
     }
@@ -5365,6 +5366,7 @@ PyUFunc_RegisterLoopForType(PyUFuncObject *ufunc,
     /* Get entry for this user-defined type*/
     cobj = PyDict_GetItemWithError(ufunc->userloops, key);
     if (cobj == NULL && PyErr_Occurred()) {
+        Py_DECREF(key);
         return 0;
     }
     /* If it's not there, then make one and return. */

Original file line number	Diff line number	Diff line change
`@@ -5228,6 +5228,7 @@ PyUFunc_RegisterLoopForDescr(PyUFuncObject *ufunc,`
`5228`	`5228`
`5229`	`5229`	`arg_typenums = PyArray_malloc(ufunc->nargs * sizeof(int));`
`5230`	`5230`	`if (arg_typenums == NULL) {`
	`5231`	`+ Py_DECREF(key);`
`5231`	`5232`	`PyErr_NoMemory();`
`5232`	`5233`	`return -1;`
`5233`	`5234`	`}`
`@@ -5365,6 +5366,7 @@ PyUFunc_RegisterLoopForType(PyUFuncObject *ufunc,`
`5365`	`5366`	`/* Get entry for this user-defined type*/`
`5366`	`5367`	`cobj = PyDict_GetItemWithError(ufunc->userloops, key);`
`5367`	`5368`	`if (cobj == NULL && PyErr_Occurred()) {`
	`5369`	`+ Py_DECREF(key);`
`5368`	`5370`	`return 0;`
`5369`	`5371`	`}`
`5370`	`5372`	`/* If it's not there, then make one and return. */`