BUG: Fix signature_tuple refcount in ufunc loop registration

seberg · seberg · commit c6fdddeddbbe · 2021-07-27T14:47:23.000-07:00
diff --git a/numpy/core/src/umath/ufunc_object.c b/numpy/core/src/umath/ufunc_object.c
@@ -5560,6 +5560,8 @@ PyUFunc_RegisterLoopForType(PyUFuncObject *ufunc,
             goto fail;
         }
     }
+    /* Clearing sets it to NULL for the error paths */
+    Py_CLEAR(signature_tuple);
 
     funcdata->func = function;
     funcdata->arg_types = newtypes;
@@ -5630,7 +5632,6 @@ PyUFunc_RegisterLoopForType(PyUFuncObject *ufunc,
         }
     }
     Py_DECREF(key);
-    Py_DECREF(signature_tuple);
     return 0;
 
  fail:

Original file line number	Diff line number	Diff line change
`@@ -5560,6 +5560,8 @@ PyUFunc_RegisterLoopForType(PyUFuncObject *ufunc,`
`5560`	`5560`	`goto fail;`
`5561`	`5561`	`}`
`5562`	`5562`	`}`
	`5563`	`+ /* Clearing sets it to NULL for the error paths */`
	`5564`	`+ Py_CLEAR(signature_tuple);`
`5563`	`5565`
`5564`	`5566`	`funcdata->func = function;`
`5565`	`5567`	`funcdata->arg_types = newtypes;`
`@@ -5630,7 +5632,6 @@ PyUFunc_RegisterLoopForType(PyUFuncObject *ufunc,`
`5630`	`5632`	`}`
`5631`	`5633`	`}`
`5632`	`5634`	`Py_DECREF(key);`
`5633`		`- Py_DECREF(signature_tuple);`
`5634`	`5635`	`return 0;`
`5635`	`5636`
`5636`	`5637`	`fail:`