Disable the Windows Error Reporting dialog by default

Author: asmichi

src/ChildProcess/Interop/Windows/Kernel32.JobObject.cs

@@ -13,6 +13,7 @@ internal static partial class Kernel32
         // https://docs.microsoft.com/en-us/windows/win32/procthread/job-objects
         // JOBOBJECT_BASIC_LIMIT_INFORMATION.LimitFlags
         public const int JOB_OBJECT_LIMIT_BREAKAWAY_OK = 0x00000800;
+        public const int JOB_OBJECT_LIMIT_DIE_ON_UNHANDLED_EXCEPTION = 0x00000400;
         public const int JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE = 0x00002000;
 
         [DllImport(DllName, EntryPoint = "CreateJobObjectW", SetLastError = true, CharSet = CharSet.Unicode)]

src/ChildProcess/ProcessManagement/ChildProcessStartInfo.cs

@@ -80,6 +80,22 @@ public enum ChildProcessFlags
         /// This effectively gives you full control over the environment variables of the child process.
         /// </summary>
         DisableEnvironmentVariableInheritance = 0x0020,
+
+        /// <summary>
+        /// (Windows-specific) Allows the child process to show the Windows Error Reporting dialog.
+        /// This includes the "foo.dll was not found" dialog and the JIT debug dialog.
+        /// </summary>
+        /// <remarks>
+        /// <para>
+        /// This flag does not work if the current process has the Windows Error Reporting dialog disabled
+        /// by calling SetErrorMode. The error mode will be inherited by the child process.
+        /// </para>
+        /// <para>
+        /// This is done by removing the <a href="https://docs.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-jobobject_basic_limit_information">
+        /// JOB_OBJECT_LIMIT_DIE_ON_UNHANDLED_EXCEPTION</a> flag. (<see cref="ChildProcess"/> adds it by default.)
+        /// </para>
+        /// </remarks>
+        EnableWindowsErrorReportingDialog = 0x0040,
     }
 
     /// <summary>
@@ -93,6 +109,7 @@ internal static class ChildProcessFlagsExtensions
         public static bool HasAttachToCurrentConsole(this ChildProcessFlags flags) => (flags & ChildProcessFlags.AttachToCurrentConsole) != 0;
         public static bool HasDisableArgumentQuoting(this ChildProcessFlags flags) => (flags & ChildProcessFlags.DisableArgumentQuoting) != 0;
         public static bool HasDisableEnvironmentVariableInheritance(this ChildProcessFlags flags) => (flags & ChildProcessFlags.DisableEnvironmentVariableInheritance) != 0;
+        public static bool HasEnableWindowsErrorReportingDialog(this ChildProcessFlags flags) => (flags & ChildProcessFlags.EnableWindowsErrorReportingDialog) != 0;
     }
 
     /// <summary>

src/ChildProcess/ProcessManagement/ChildProcessStartInfoInternal.cs

@@ -98,5 +98,6 @@ public ChildProcessStartInfoInternal(ChildProcessStartInfo startInfo)
         }
 
         public bool AllowSignal => !Flags.HasAttachToCurrentConsole();
+        public bool DisableWindowsErrorReportingDialog => !Flags.HasEnableWindowsErrorReportingDialog();
     }
 }

src/ChildProcess/ProcessManagement/WindowsChildProcessStateHelper.cs

@@ -56,7 +56,7 @@ public unsafe IChildProcessStateHolder SpawnProcess(
                 }
 
                 bool killOnClose = startInfo.AllowSignal && WindowsVersion.NeedsWorkaroundForWindows1809;
-                jobObjectHandle = CreateJobObject(killOnClose);
+                jobObjectHandle = CreateJobObject(killOnClose, startInfo.DisableWindowsErrorReportingDialog);
 
                 using var inheritableHandleStore = new InheritableHandleStore(3);
                 var childStdIn = stdIn != null ? inheritableHandleStore.Add(stdIn) : null;
@@ -187,7 +187,9 @@ private static unsafe void ChangeCodePage(
             }
         }
 
-        private static unsafe SafeJobObjectHandle CreateJobObject(bool killOnClose)
+        private static unsafe SafeJobObjectHandle CreateJobObject(
+            bool killOnClose,
+            bool disableWindowsErrorReportingDialog)
         {
             var jobObjectHandle = Kernel32.CreateJobObject(IntPtr.Zero, null);
             try
@@ -198,6 +200,10 @@ private static unsafe SafeJobObjectHandle CreateJobObject(bool killOnClose)
                 }
 
                 var limitFlags = Kernel32.JOB_OBJECT_LIMIT_BREAKAWAY_OK;
+                if (disableWindowsErrorReportingDialog)
+                {
+                    limitFlags |= Kernel32.JOB_OBJECT_LIMIT_DIE_ON_UNHANDLED_EXCEPTION;
+                }
                 if (killOnClose)
                 {
                     limitFlags |= Kernel32.JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE;