Merge pull request #558 from asomers/clone_from

asomers · web-flow · commit 1b4838237259 · 2024-03-09T08:21:31.000-07:00
Clippy: fix a assigning_clones lint
diff --git a/mockall_derive/src/lib.rs b/mockall_derive/src/lib.rs
@@ -1041,7 +1041,7 @@ fn merge_generics(x: &Generics, y: &Generics) -> Generics {
                         ot.colon_token = ot.colon_token.or(yt.colon_token);
                         ot.eq_token = ot.eq_token.or(yt.eq_token);
                         if ot.default.is_none() {
-                            ot.default = yt.default.clone();
+                            ot.default.clone_from(&yt.default);
                         }
                         // XXX this might result in duplicate bounds
                         if ot.bounds != yt.bounds {

Original file line number	Diff line number	Diff line change
`@@ -1041,7 +1041,7 @@ fn merge_generics(x: &Generics, y: &Generics) -> Generics {`
`1041`	`1041`	`ot.colon_token = ot.colon_token.or(yt.colon_token);`
`1042`	`1042`	`ot.eq_token = ot.eq_token.or(yt.eq_token);`
`1043`	`1043`	`if ot.default.is_none() {`
`1044`		`- ot.default = yt.default.clone();`
	`1044`	`+ ot.default.clone_from(&yt.default);`
`1045`	`1045`	`}`
`1046`	`1046`	`// XXX this might result in duplicate bounds`
`1047`	`1047`	`if ot.bounds != yt.bounds {`