simplify red() with PyArg_ParseTuple_s

Author: asottile

red_proj/red.c

@@ -4,8 +4,8 @@
 PyObject* red(PyObject*);
 
 /* To shim go's missing variadic function support */
-int PyArg_ParseTuple_U(PyObject* args, PyObject** obj) {
-    return PyArg_ParseTuple(args, "U", obj);
+int PyArg_ParseTuple_s(PyObject* args, char** obj) {
+    return PyArg_ParseTuple(args, "s", obj);
 }
 
 static struct PyMethodDef methods[] = {

red_proj/red.go

@@ -2,25 +2,22 @@ package main
 
 // #include <stdlib.h>
 // #include <Python.h>
-// int PyArg_ParseTuple_U(PyObject*, PyObject**);
+// int PyArg_ParseTuple_s(PyObject*, char**);
 import "C"
 import "unsafe"
 import "github.com/mgutz/ansi"
 
 //export red
 func red(self *C.PyObject, args *C.PyObject) *C.PyObject {
-	var obj *C.PyObject
-	if C.PyArg_ParseTuple_U(args, &obj) == 0 {
+	var cstr *C.char
+	if C.PyArg_ParseTuple_s(args, &cstr) == 0 {
 		return nil
 	}
-	bytes := C.PyUnicode_AsUTF8String(obj)
-	cstr := C.PyBytes_AsString(bytes)
 	red := ansi.Color(C.GoString(cstr), "red")
-	cstr = C.CString(red)
-	ret := C.PyUnicode_FromString(cstr)
 
-	C.free(unsafe.Pointer(cstr))
-	C.Py_DecRef(bytes)
+	gocstr := C.CString(red)
+	ret := C.PyUnicode_FromString(gocstr)
+	C.free(unsafe.Pointer(gocstr))
 
 	return ret
 }