refactor: use simplified empty-array literals

Author: jbedard

language/js/node/package.go

@@ -30,7 +30,7 @@ func ParsePackageJsonImports(packageJsonReader io.Reader) ([]string, error) {
 		return nil, err
 	}
 
-	imports := make([]string, 0)
+	imports := []string{}
 
 	if c.Main != "" {
 		imports = append(imports, path.Clean(c.Main))

language/js/proto/proto.go

@@ -58,7 +58,7 @@ func GetProtoImports(filepath string) ([]string, error) {
 		return nil, err
 	}
 
-	imports := make([]string, 0)
+	imports := []string{}
 
 	for _, match := range protoRe.FindAllSubmatch(content, -1) {
 		switch {

language/kotlin/parser/parser.go

@@ -59,7 +59,7 @@ const importsQuery = `
 func (p *treeSitterParser) Parse(filePath string, sourceCode []byte) (*ParseResult, []error) {
 	var result = &ParseResult{
 		File:    filePath,
-		Imports: make([]string, 0),
+		Imports: []string{},
 	}
 
 	errs := make([]error, 0)

language/orion/host.go

@@ -263,7 +263,7 @@ func (h *GazelleHost) ApparentLoads(moduleToApparentName func(string) string) []
 				loads[fromStr] = &rule.LoadInfo{
 					Name:    fromStr,
 					Symbols: make([]string, 0, 1),
-					After:   make([]string, 0),
+					After:   []string{},
 				}
 			}
 

runner/pkg/git/gitignore_test.go

@@ -192,7 +192,7 @@ func TestGitIgnore(t *testing.T) {
 // Util method to invoke GitIgnore.AddIgnore() with the trimmed string
 // value to allow tests to be written with multiline strings including indentation.
 func addIgnoreFileContent(parentPatterns []gitignore.Pattern, rel, ignoreContents string) (isGitIgnored, []gitignore.Pattern) {
-	ignoreLines := make([]string, 0)
+	ignoreLines := []string{}
 	for line := range strings.SplitSeq(ignoreContents, "\n") {
 		if trimmdLine := strings.TrimSpace(line); trimmdLine != "" {
 			ignoreLines = append(ignoreLines, trimmdLine)

runner/pkg/watchman/watch.go

@@ -207,7 +207,7 @@ func (w *WatchmanWatcher) GetDiff(clockspec string) (*ChangeSet, error) {
 		return nil, fmt.Errorf("query error response: %s", resp["error"])
 	}
 
-	files := make([]string, 0)
+	files := []string{}
 
 	if resp["files"] != nil {
 		rf := resp["files"].([]interface{})
@@ -416,7 +416,7 @@ func (w *WatchmanWatcher) Subscribe(ctx context.Context, dropWithinState string)
 				return
 			}
 
-			files := make([]string, 0)
+			files := []string{}
 
 			if resp["files"] != nil {
 				rf := resp["files"].([]interface{})