refactor: only sort orion plugins loaded by glob, not explicit list

jbedard · jbedard · commit 7c29ebe7fc1e · 2025-10-23T15:32:15.000-07:00
diff --git a/language/orion/host.go b/language/orion/host.go
@@ -122,16 +122,16 @@ func (h *GazelleHost) loadEnvStarzellePlugins() {
 			BazelLog.Warnf("No orion plugins found in %q", builtinPluginDir)
 		}
 
+		// Sort to ensure a consistent order not dependent on the fs or glob ordering.
+		sort.Strings(builtinDirPlugins)
+
 		builtinPlugins = append(builtinPlugins, builtinDirPlugins...)
 	}
 
 	if len(builtinPlugins) == 0 {
 		return
 	}
 
-	// Sort to ensure a consistent order not dependent on the fs or glob ordering.
-	sort.Strings(builtinPlugins)
-
 	// Split the plugin paths to dir + rel for better logging and load API
 	// Only relativize if builtinPluginDir is not absolute
 	for i, p := range builtinPlugins {

Original file line number	Diff line number	Diff line change
`@@ -122,16 +122,16 @@ func (h *GazelleHost) loadEnvStarzellePlugins() {`
`122`	`122`	`BazelLog.Warnf("No orion plugins found in %q", builtinPluginDir)`
`123`	`123`	`}`
`124`	`124`
	`125`	`+ // Sort to ensure a consistent order not dependent on the fs or glob ordering.`
	`126`	`+ sort.Strings(builtinDirPlugins)`
	`127`	`+`
`125`	`128`	`builtinPlugins = append(builtinPlugins, builtinDirPlugins...)`
`126`	`129`	`}`
`127`	`130`
`128`	`131`	`if len(builtinPlugins) == 0 {`
`129`	`132`	`return`
`130`	`133`	`}`
`131`	`134`
`132`		`- // Sort to ensure a consistent order not dependent on the fs or glob ordering.`
`133`		`- sort.Strings(builtinPlugins)`
`134`		`-`
`135`	`135`	`// Split the plugin paths to dir + rel for better logging and load API`
`136`	`136`	`// Only relativize if builtinPluginDir is not absolute`
`137`	`137`	`for i, p := range builtinPlugins {`