refactor: rename starlark register_configure_extension API to register_orion_plugin (#80)

### Changes are visible to end-users: yes

- Searched for relevant documentation and updated as needed: yes
- Breaking change (forces users to change their own code or config): no
- Suggested release notes appear below: yes

The Orion plugin API has been renamed from the legacy aspect-cli
`register_configure_extension`+`register_rule_kind` terminology to `orion_extension` and `gazelle_rule_kind`.

The legacy methods are DEPRECATED but will remain for backwards compatibility.

### Test plan

- Covered by existing test cases
- New test cases added

Author: jbedard

language/orion/plugins/bzl.axl

@@ -3,7 +3,7 @@ BZL_LIBRARY = "bzl_library"
 LANG_NAME = "starlark"
 BZL_EXT = ".bzl"
 
-aspect.register_rule_kind(BZL_LIBRARY, {
+aspect.gazelle_rule_kind(BZL_LIBRARY, {
     "From": "@bazel_skylib//:bzl_library.bzl",
     "NonEmptyAttrs": ["srcs"],
     "MergeableAttrs": ["srcs"],
@@ -74,7 +74,7 @@ def declare_targets(ctx):
         )
     return {}
 
-aspect.register_configure_extension(
+aspect.orion_extension(
     id = LANG_NAME,
     properties = {},
     prepare = prepare,

language/orion/plugins/ext.axl.tmpl

@@ -96,7 +96,7 @@ def is_native(imp):
 
     return False
 
-aspect.register_rule_kind("my_rule", {
+aspect.gazelle_rule_kind("my_rule", {
     "From": "@my_ruleset//:defs.bzl",
     "NonEmptyAttrs": ["srcs"],
     "MergeableAttrs": ["srcs"],

language/orion/plugins/kotlin.axl

@@ -9,14 +9,14 @@ PROVIDER_NAME = "kt"
 
 LANG_NAME = "kotlin"
 
-aspect.register_rule_kind(KT_JVM_LIBRARY, {
+aspect.gazelle_rule_kind(KT_JVM_LIBRARY, {
     "From": "@" + RULES_KOTLIN_REPO_NAME + "//kotlin:jvm.bzl",
     "NonEmptyAttrs": ["srcs"],
     "MergeableAttrs": ["srcs"],
     "ResolveAttrs": ["deps"],
 })
 
-aspect.register_rule_kind(KT_JVM_BINARY, {
+aspect.gazelle_rule_kind(KT_JVM_BINARY, {
     "From": "@" + RULES_KOTLIN_REPO_NAME + "//kotlin:jvm.bzl",
     "NonEmptyAttrs": ["srcs", "main_class"],
 })
@@ -183,7 +183,7 @@ def is_native(imp):
 
     return False
 
-aspect.register_configure_extension(
+aspect.orion_extension(
     id = LANG_NAME,
     properties = {},
     prepare = prepare,

language/orion/plugins/maven.axl

@@ -33,7 +33,7 @@ def declare_maven_targets(ctx):
                 ),
             )
 
-aspect.register_configure_extension(
+aspect.orion_extension(
     id = "maven",
     properties = {
         JAVA_MAVEN_INSTALL_FILE: aspect.Property(

language/orion/starzelle/sdk.go

@@ -15,13 +15,18 @@ import (
 	"go.starlark.net/starlark"
 )
 
-func registerConfigureExtension(t *starlark.Thread, b *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
+func deprecatedRegisterConfigureExtension(t *starlark.Thread, b *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
+	fmt.Printf("DEPRECATED: 'register_configure_extension' is deprecated, please use 'orion_extension' instead.\n")
+	return registerOrionPlugin(t, b, args, kwargs)
+}
+
+func registerOrionPlugin(t *starlark.Thread, b *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
 	var pluginId starlark.String
 	var properties *starlark.Dict
 	var prepare, analyze, declare *starlark.Function
 
 	err := starlark.UnpackArgs(
-		"register_configure_extension",
+		"orion_extension",
 		args,
 		kwargs,
 		"id", &pluginId,
@@ -46,12 +51,18 @@ func registerConfigureExtension(t *starlark.Thread, b *starlark.Builtin, args st
 	return starlark.None, err
 }
 
-func registerRuleKind(t *starlark.Thread, b *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
+func deprecatedRegisterRuleKind(t *starlark.Thread, b *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
+	fmt.Printf("DEPRECATED: 'register_rule_kind' is deprecated, please use 'gazelle_rule_kind' instead.\n")
+
+	return registerGazelleRuleKind(t, b, args, kwargs)
+}
+
+func registerGazelleRuleKind(t *starlark.Thread, b *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) {
 	var kind starlark.String
 	var attributes *starlark.Dict
 
 	err := starlark.UnpackArgs(
-		"register_rule_kind",
+		"gazelle_rule_kind",
 		args,
 		kwargs,
 		"name", &kind,
@@ -443,8 +454,10 @@ func newProperty(_ *starlark.Thread, b *starlark.Builtin, args starlark.Tuple, k
 var aspectModule = starUtils.CreateModule(
 	"aspect",
 	map[string]starUtils.ModuleFunction{
-		"register_configure_extension": registerConfigureExtension,
-		"register_rule_kind":           registerRuleKind,
+		"register_configure_extension": deprecatedRegisterConfigureExtension,
+		"register_rule_kind":           deprecatedRegisterRuleKind,
+		"orion_extension":              registerOrionPlugin,
+		"gazelle_rule_kind":            registerGazelleRuleKind,
 		"AstQuery":                     newAstQuery,
 		"RegexQuery":                   newRegexQuery,
 		"RawQuery":                     newRawQuery,

language/orion/tests/starzelle/attr-types/attr-types.axl

@@ -1,4 +1,4 @@
-aspect.register_rule_kind("x_lib", {
+aspect.gazelle_rule_kind("x_lib", {
     "From": "@deps-test//my:rules.bzl",
     "ResolveAttrs": ["deps"],
 })
@@ -94,7 +94,7 @@ def declare(ctx):
         )],
     )
 
-aspect.register_configure_extension(
+aspect.orion_extension(
     id = "attribute-types-test",
     declare = declare,
 )

language/orion/tests/starzelle/bad_prepareresult/bad-prep.axl

@@ -1,4 +1,4 @@
-aspect.register_configure_extension(
+aspect.orion_extension(
     id = "bad_prepareresult-bool",
     prepare = lambda _ : aspect.PrepareResult(
         sources = aspect.SourceGlobs(True, 3, [4]),

language/orion/tests/starzelle/builtins/copy-txt.axl

@@ -16,7 +16,7 @@ def declare_targets(ctx):
         },
     )
 
-aspect.register_configure_extension(
+aspect.orion_extension(
     id = "copy-txt",
     prepare = prepare,
     declare = declare_targets,

language/orion/tests/starzelle/builtins/filegroup.axl

@@ -18,7 +18,7 @@ def declare_targets(ctx):
         },
     )
 
-aspect.register_configure_extension(
+aspect.orion_extension(
     id = "fgs",
     prepare = prepare,
     declare = declare_targets,