refactor: make use of strings.Cut

Author: jbedard

language/js/configure.go

@@ -210,19 +210,19 @@ func (ts *typeScriptLang) readDirectives(c *config.Config, rel string, f *rule.F
 			group := DefaultLibraryName
 			groupGlob := value
 
-			if i := strings.Index(value, " "); i != -1 {
-				group = value[:i]
-				groupGlob = strings.TrimSpace(value[i+1:])
+			if before, after, found := strings.Cut(value, " "); found {
+				group = before
+				groupGlob = strings.TrimSpace(after)
 			}
 
 			config.addTargetGlob(group, groupGlob, false)
 		case Directive_TestFiles:
 			group := DefaultTestsName
 			groupGlob := value
 
-			if i := strings.Index(value, " "); i != -1 {
-				group = value[:i]
-				groupGlob = strings.TrimSpace(value[i+1:])
+			if before, after, found := strings.Cut(value, " "); found {
+				group = before
+				groupGlob = strings.TrimSpace(after)
 			}
 
 			config.addTargetGlob(group, groupGlob, true)

runner/bin/gazelle/main.go

@@ -122,7 +122,7 @@ func extractArg(flag string, defaultValue string, args []string) (string, []stri
 		return value, args
 	}
 
-	value := strings.SplitN(args[i], "=", 2)[1]
+	_, value, _ := strings.Cut(args[i], "=")
 	args = append(args[:i], args[i+1:]...)
 	return value, args
 }

runner/pkg/git/gitignore_test.go

@@ -12,8 +12,7 @@ func TestGitIgnore(t *testing.T) {
 	shouldMatch := func(what string, matcher isGitIgnored, matches ...string) {
 		for _, m := range matches {
 			// Use trailing slash in test data to indicate directory
-			isDir := strings.HasSuffix(m, "/")
-			m = strings.TrimSuffix(m, "/")
+			m, isDir := strings.CutSuffix(m, "/")
 
 			if !(matcher != nil && matcher(m, isDir)) {
 				t.Error(fmt.Sprintf("%s should match '%s'", what, m))
@@ -23,8 +22,7 @@ func TestGitIgnore(t *testing.T) {
 	shouldNotMatch := func(what string, matcher isGitIgnored, matches ...string) {
 		for _, m := range matches {
 			// Use trailing slash in test data to indicate directory
-			isDir := strings.HasSuffix(m, "/")
-			m = strings.TrimSuffix(m, "/")
+			m, isDir := strings.CutSuffix(m, "/")
 
 			if matcher != nil && matcher(m, isDir) {
 				t.Error(fmt.Sprintf("%s should NOT match '%s'", what, m))