refactor: validate orion axl types everywhere (#113)

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases
- New test cases added

Author: jbedard

language/orion/MODULE.bazel

@@ -10,7 +10,7 @@ bazel_dep(name = "gazelle", version = "0.45.0")
 # Go modules
 go_deps = use_extension("@gazelle//:extensions.bzl", "go_deps")
 go_deps.from_file(go_mod = "//:go.mod")
-use_repo(go_deps, "com_github_bmatcuk_doublestar_v4", "com_github_emirpasic_gods", "com_github_itchyny_gojq", "com_github_mikefarah_yq_v4", "net_starlark_go", "org_golang_x_sync")
+use_repo(go_deps, "com_github_bazelbuild_buildtools", "com_github_bmatcuk_doublestar_v4", "com_github_emirpasic_gods", "com_github_itchyny_gojq", "com_github_mikefarah_yq_v4", "net_starlark_go", "org_golang_x_sync")
 
 ####### Dev dependencies ########
 

language/orion/go.mod

@@ -6,7 +6,7 @@ replace github.com/aspect-build/aspect-gazelle/common => ../../common
 
 require (
 	github.com/bazelbuild/bazel-gazelle v0.45.0 // NOTE: keep in sync with MODULE.bazel
-	github.com/bazelbuild/buildtools v0.0.0-20250930140053-2eb4fccefb52 // indirect
+	github.com/bazelbuild/buildtools v0.0.0-20250930140053-2eb4fccefb52
 	github.com/bmatcuk/doublestar/v4 v4.9.1
 	github.com/emirpasic/gods v1.18.1
 	github.com/fatih/color v1.18.0 // indirect

language/orion/host.go

@@ -163,14 +163,14 @@ func (h *GazelleHost) LoadPlugin(pluginDir, pluginPath string) {
 
 	err := starzelle.LoadProxy(h, pluginDir, pluginPath)
 	if err != nil {
-		BazelLog.Infof("Failed to load orion plugin %q/%q: %v\n", pluginDir, pluginPath, err)
+		BazelLog.Infof("Failed to load orion plugin %v\n", err)
 
 		// Try to remove the `parentDir` from the error message to align paths
 		// with the user's workspace relative paths, and to remove sandbox paths
 		// when run in tests.
 		errStr := strings.ReplaceAll(err.Error(), pluginDir+"/", "")
 
-		fmt.Printf("Failed to load orion plugin %q: %v\n", pluginPath, errStr)
+		fmt.Printf("Failed to load orion plugin %v\n", errStr)
 		return
 	}
 }

language/orion/plugin/BUILD.bazel

@@ -4,6 +4,7 @@ go_library(
     name = "plugin",
     srcs = [
         "database.go",
+        "plugin.bzl.go",
         "plugin.go",
         "plugin.star.go",
         "queries.go",
@@ -15,7 +16,9 @@ go_library(
     visibility = ["//visibility:public"],
     deps = [
         "//starlark/utils",
+        "@com_github_bazelbuild_buildtools//build",
         "@com_github_bmatcuk_doublestar_v4//:doublestar",
+        "@gazelle//rule",
         "@net_starlark_go//starlark",
     ],
 )

language/orion/plugin/plugin.bzl.go

@@ -0,0 +1,14 @@
+package plugin
+
+import (
+	"github.com/bazelbuild/bazel-gazelle/rule"
+	bzl "github.com/bazelbuild/buildtools/build"
+)
+
+// ---------------- TargetSource
+
+var _ rule.BzlExprValue = (*TargetSource)(nil)
+
+func (ts TargetSource) BzlExpr() bzl.Expr {
+	return &bzl.StringExpr{Value: ts.Path}
+}

language/orion/plugin/plugin.star.go

@@ -251,12 +251,18 @@ func addTarget(thread *starlark.Thread, fn *starlark.Builtin, args starlark.Tupl
 
 	var attrs map[string]interface{}
 	if starAttrs != nil {
-		attrs = starUtils.ReadMap2(starAttrs, readTargetAttributeValue)
+		attrs, err = starUtils.ReadMap2(starAttrs, readTargetAttributeValue)
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	var symbols []Symbol
 	if starSymbols != nil {
-		symbols = starUtils.ReadList(starSymbols, readSymbol)
+		symbols, err = starUtils.ReadList(starSymbols, readSymbol)
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	ai := fn.Receiver().(*declareTargetActionsImpl)

language/orion/plugin/target.star.go

@@ -103,26 +103,23 @@ func (te TargetSymbol) AttrNames() []string {
 
 // ---------------- utils
 
-func readTargetImport(v starlark.Value) TargetImport {
-	return v.(TargetImport)
-}
-
-func readSymbol(v starlark.Value) Symbol {
-	return v.(Symbol)
-}
-
-func readLabel(v starlark.Value) Label {
-	return v.(Label)
+func readSymbol(v starlark.Value) (Symbol, error) {
+	s, ok := v.(Symbol)
+	if !ok {
+		return Symbol{}, fmt.Errorf("expected Symbol, got %T", v)
+	}
+	return s, nil
 }
 
-func readTargetAttributeValue(v starlark.Value) interface{} {
+func readTargetAttributeValue(v starlark.Value) (interface{}, error) {
+	// Types that are both starlark.Value and plugin.*
 	switch v := v.(type) {
 	case TargetImport:
-		return readTargetImport(v)
+		return v, nil
 	case Label:
-		return readLabel(v)
+		return v, nil
 	case TargetSource:
-		return v.Path
+		return v, nil
 	}
 
 	return starUtils.ReadRecurse(v, readTargetAttributeValue)

language/orion/starlark/stdlib/path.go

@@ -1,6 +1,7 @@
 package starlark
 
 import (
+	"fmt"
 	"path"
 
 	utils "github.com/aspect-build/aspect-gazelle/language/orion/starlark/utils"
@@ -36,7 +37,11 @@ func path_ext(_ *starlark.Thread, b *starlark.Builtin, args starlark.Tuple, kwar
 }
 
 func path_join(_ *starlark.Thread, b *starlark.Builtin, args starlark.Tuple, _ []starlark.Tuple) (starlark.Value, error) {
-	return starlark.String(path.Join(utils.ReadStringTuple(args)...)), nil
+	parts, err := utils.ReadStringTuple(args)
+	if err != nil {
+		return nil, fmt.Errorf("path.join: %w", err)
+	}
+	return starlark.String(path.Join(parts...)), nil
 }
 
 var Path = utils.CreateModule("path", map[string]utils.ModuleFunction{