build: enable aspect-configure in pnpm-workspaces, adopt recommendations

Author: jbedard

pnpm-workspaces/.aspect/cli/config.yaml

@@ -0,0 +1,3 @@
+configure:
+  languages:
+    javascript: true

pnpm-workspaces/BUILD.bazel

@@ -1,15 +1,30 @@
+load("@aspect_rules_js//js:defs.bzl", "js_library")
 load("@aspect_rules_ts//ts:defs.bzl", "ts_config")
 load("@npm//:defs.bzl", "npm_link_all_packages")
 load("@npm//:tsconfig-to-swcconfig/package_json.bzl", tsconfig_to_swcconfig = "bin")
 
-# link all dependencies from root package.json
+# aspect:generation_mode update
+
+# aspect:map_kind ts_project ts_project //:defs.bzl
+
+# aspect:js enabled
+# aspect:js_tsconfig enabled
+# aspect:js_npm_package enabled
+
+# aspect:js_files **/*.{js,ts}
+# aspect:js_npm_package_target_name pkg
+# aspect:js_package_rule_kind js_library
+# aspect:js_project_naming_convention tsc
+
 npm_link_all_packages(name = "node_modules")
 
 ts_config(
     name = "tsconfig",
     src = "tsconfig.json",
     visibility = ["//visibility:public"],
-    deps = ["//:node_modules/@tsconfig/node16-strictest"],
+    deps = [
+        "//:node_modules/@tsconfig/node16-strictest",  #keep
+    ],
 )
 
 tsconfig_to_swcconfig.t2s(
@@ -18,3 +33,8 @@ tsconfig_to_swcconfig.t2s(
     stdout = ".swcrc",
     visibility = ["//:__subpackages__"],
 )
+
+js_library(
+    name = "pkg",
+    srcs = ["package.json"],
+)

pnpm-workspaces/apps/alpha/BUILD.bazel

@@ -1,23 +1,29 @@
-load("@aspect_rules_js//js:defs.bzl", "js_binary")
+load("@aspect_rules_js//js:defs.bzl", "js_binary", "js_library")
 load("@npm//:defs.bzl", "npm_link_all_packages")
 load("//:defs.bzl", "ts_project")
 
 npm_link_all_packages(name = "node_modules")
 
 ts_project(
-    name = "pkg",
+    name = "tsc",
     srcs = ["src/main.ts"],
     declaration = True,
     tsconfig = "//:tsconfig",
     deps = [
         ":node_modules/inspirational-quotes",  # this uses the version defined in the local package.json
         "//:node_modules/@bazel-poc/one",
         "//:node_modules/@bazel-poc/shared",
-        "//:node_modules/@types/node",
+        "//:node_modules/@types/node",  # keep
         "//:node_modules/star-wars-quotes",
     ],
 )
 
+js_library(
+    name = "pkg",
+    srcs = ["package.json"],
+    deps = [":tsc"],
+)
+
 js_binary(
     name = "main",
     data = [":pkg"],

pnpm-workspaces/apps/beta/BUILD.bazel

@@ -1,7 +1,7 @@
 load("@aspect_rules_js//js:defs.bzl", "js_binary", "js_library")
 
 js_library(
-    name = "pkg",
+    name = "tsc",
     srcs = ["src/main.js"],
     deps = [
         "//:node_modules/@bazel-poc/shared",
@@ -13,6 +13,6 @@ js_library(
 
 js_binary(
     name = "main",
-    data = [":pkg"],
+    data = [":tsc"],
     entry_point = "src/main.js",
 )

pnpm-workspaces/packages/first/BUILD.bazel

@@ -1,11 +1,16 @@
-load("@aspect_rules_js//npm:defs.bzl", "npm_package")
+load("@aspect_rules_js//js:defs.bzl", "js_library")
+load("@npm//:defs.bzl", "npm_link_all_packages")
 
-# make this library available via node_modules
-npm_package(
+npm_link_all_packages(name = "node_modules")
+
+js_library(
+    name = "tsc",
+    srcs = ["src/main.js"],
+)
+
+js_library(
     name = "pkg",
-    srcs = [
-        "package.json",
-        "src/main.js",
-    ],
+    srcs = ["package.json"],
     visibility = ["//visibility:public"],
+    deps = [":tsc"],
 )

pnpm-workspaces/packages/one/BUILD.bazel

@@ -1,22 +1,22 @@
-load("@aspect_rules_js//npm:defs.bzl", "npm_package")
+load("@aspect_rules_js//js:defs.bzl", "js_library")
+load("@npm//:defs.bzl", "npm_link_all_packages")
 load("//:defs.bzl", "ts_project")
 
+npm_link_all_packages(name = "node_modules")
+
 ts_project(
-    name = "one_lib",
+    name = "tsc",
     srcs = ["src/main.ts"],
     declaration = True,
     tsconfig = "//:tsconfig",
     deps = [
-        "//:node_modules/@types/node",
+        "//:node_modules/@types/node",  # keep
     ],
 )
 
-# make this library available via node_modules
-npm_package(
+js_library(
     name = "pkg",
-    srcs = [
-        "package.json",
-        ":one_lib",
-    ],
+    srcs = ["package.json"],
     visibility = ["//visibility:public"],
+    deps = [":tsc"],
 )

pnpm-workspaces/packages/shared/BUILD.bazel

@@ -1,22 +1,22 @@
-load("@aspect_rules_js//npm:defs.bzl", "npm_package")
+load("@aspect_rules_js//js:defs.bzl", "js_library")
+load("@npm//:defs.bzl", "npm_link_all_packages")
 load("//:defs.bzl", "ts_project")
 
+npm_link_all_packages(name = "node_modules")
+
 ts_project(
-    name = "shared_lib",
+    name = "tsc",
     srcs = ["src/main.ts"],
     declaration = True,
     tsconfig = "//:tsconfig",
     deps = [
-        "//:node_modules/@types/node",
+        "//:node_modules/@types/node",  # keep
     ],
 )
 
-# make this library available via node_modules
-npm_package(
+js_library(
     name = "pkg",
-    srcs = [
-        "package.json",
-        "src/main.js",
-    ],
+    srcs = ["package.json"],
     visibility = ["//visibility:public"],
+    deps = [":tsc"],
 )

pnpm-workspaces/packages/two/BUILD.bazel

@@ -1,15 +1,20 @@
-load("@aspect_rules_js//npm:defs.bzl", "npm_package")
+load("@aspect_rules_js//js:defs.bzl", "js_library")
+load("@npm//:defs.bzl", "npm_link_all_packages")
 
-# make this library available via node_modules
-npm_package(
-    name = "pkg",
-    srcs = [
-        "package.json",
-        "src/main.js",
-    ],
-    data = [
+npm_link_all_packages(name = "node_modules")
+
+js_library(
+    name = "tsc",
+    srcs = ["src/main.js"],
+    deps = [
         "//:node_modules/@bazel-poc/first",
         "//:node_modules/cowsay",
     ],
+)
+
+js_library(
+    name = "pkg",
+    srcs = ["package.json"],
     visibility = ["//visibility:public"],
+    deps = [":tsc"],
 )