Skip to content

Commit 60c5a89

Browse files
authored
refactor: use pnpm file: id field (#2449)
... and add a `fail` in the `if` where we extract all info from the key and are assuming there is no explicit `name/version/id`. If this `fail` is ever hit we should fix it. ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases
1 parent e6346c2 commit 60c5a89

File tree

12 files changed

+192
-76
lines changed

12 files changed

+192
-76
lines changed

e2e/pnpm_lockfiles/projects/c/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
"dependencies": {
55
"@scoped/a": "link:../a"
66
},
7+
"devDependencies": {
8+
"a-types": "file:../a-types"
9+
},
710
"peerDependencies": {
811
"@scoped/b": "workspace:*"
912
}

e2e/pnpm_lockfiles/v101/pnpm-lock.yaml

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/pnpm_lockfiles/v101/snapshots/defs.bzl

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/pnpm_lockfiles/v54/pnpm-lock.yaml

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/pnpm_lockfiles/v54/snapshots/defs.bzl

Lines changed: 45 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/pnpm_lockfiles/v60/pnpm-lock.yaml

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)