Skip to content

Commit 7e0bb66

Browse files
committed
refactor: remove rules_nodejs v5 fallback
1 parent 30a9147 commit 7e0bb66

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

js/private/js_binary.bzl

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -516,13 +516,7 @@ def _create_launcher(ctx, log_prefix_rule_set, log_prefix_rule, fixed_args = [],
516516
launcher_files.extend(ctx.files._node_patches_files + [ctx.file._node_patches])
517517
transitive_launcher_files = None
518518
if ctx.attr.include_npm:
519-
if hasattr(nodeinfo, "npm_sources"):
520-
transitive_launcher_files = nodeinfo.npm_sources
521-
else:
522-
# TODO(3.0): drop support for deprecated toolchain attributes
523-
if not hasattr(nodeinfo, "npm_files"):
524-
fail("include_npm requires a minimum @rules_nodejs version of 5.7.0")
525-
launcher_files.extend(nodeinfo.npm_files)
519+
transitive_launcher_files = nodeinfo.npm_sources
526520

527521
runfiles = gather_runfiles(
528522
ctx = ctx,

0 commit comments

Comments
 (0)