Skip to content

Commit 8a818b7

Browse files
authored
Add non_ascii directory to export-ignore (#2286)
If users don't have locales setup correctly, just having this is the archive makes the download fail. If the build doesn't otherwise have non-ascii characters the fact that their locales are incorrect doesn't matter besides this failure: ``` ERROR: Skipping '//...': error loading package under directory '': no such package '@@aspect_rules_js+//js': java.io.IOException: Error extracting .../aspect_rules_js+/temp7219254014548800952/rules_js-v2.3.8.tar.gz to .../aspect_rules_js+/temp7219254014548800952: [unix_jni.cc:281] .../aspect_rules_js+/js/private/test/image/non_ascii/empty empty.?? (No such file or directory) ```
1 parent 2f49750 commit 8a818b7

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.github/workflows/release_prep.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ set -o errexit -o nounset -o pipefail
44

55
# Don't include e2e or examples in the distribution artifact, to reduce size
66
echo >.git/info/attributes "examples export-ignore"
7+
echo >>.git/info/attributes "js/private/test/image/non_ascii export-ignore"
78
# But **do** include e2e/bzlmod since the BCR wants to run presubmit test
89
# and it only sees our release artifact.
910
# shellcheck disable=2010

0 commit comments

Comments
 (0)