refactor: adopt new NodeJS runtime toolchain (#2330)

`js_binary` should use the new runtime toolchain to avoid execution
toolchain being leaked into target environments (eg., `js_image_oci`)

See bazel-contrib/rules_nodejs#3854

Depends on: 

- bazel-contrib/rules_nodejs#3859

### Changes are visible to end-users: yes

- Searched for relevant documentation and updated as needed: yes
- Breaking change (forces users to change their own code or config): no
- Suggested release notes appear below: yes

> Switched `js_binary` (and `js_test`) to start using the new runtime
toolchain type introduced by `rules_nodejs` to better support
cross-platform builds (eg., building `arm64` container from `amd64`).

### Test plan

- Covered by existing test cases

Author: guw

docs/js_binary.md

@@ -19,7 +19,7 @@ sh_test(
         "@nodejs_linux_amd64//:node_files",
         "@nodejs_linux_arm64//:node_files",
     ],
-    toolchains = ["@nodejs_toolchains//:resolved_toolchain"],
+    toolchains = ["@rules_nodejs//nodejs:current_node_runtime"],
 )
 
 build_test(

e2e/pnpm_workspace/BUILD.bazel

@@ -19,7 +19,7 @@ sh_test(
         "@nodejs_linux_amd64//:node_files",
         "@nodejs_linux_arm64//:node_files",
     ],
-    toolchains = ["@nodejs_toolchains//:resolved_toolchain"],
+    toolchains = ["@rules_nodejs//nodejs:current_node_runtime"],
 )
 
 build_test(

e2e/pnpm_workspace_rerooted/BUILD.bazel

@@ -26,6 +26,23 @@ load("@rules_nodejs//nodejs:toolchain.bzl", "nodejs_toolchain")
     ]
 ]
 
+[
+    toolchain(
+        name = "node_vendored_%s_runtime" % os,
+        target_compatible_with = [
+            "@platforms//os:" + os,
+            "@platforms//cpu:x86_64",
+        ],
+        toolchain = ":node_" + os,
+        toolchain_type = "@rules_nodejs//nodejs:runtime_toolchain_type",
+    )
+    for os in [
+        "linux",
+        "macos",
+        "windows",
+    ]
+]
+
 nodejs_toolchain(
     name = "node_linux",
     node = "@vendored_node_linux_amd64//:bin/node",

e2e/vendored_node/toolchains/BUILD.bazel

@@ -43,8 +43,8 @@ genrule(
         # $@ is bazel shorthand for the path of the output file
         ">$@",
     ]),
-    toolchains = ["@nodejs_toolchains//:resolved_toolchain"],
-    tools = ["@nodejs_toolchains//:resolved_toolchain"],
+    toolchains = ["@rules_nodejs//nodejs:current_node_toolchain"],
+    tools = ["@rules_nodejs//nodejs:current_node_toolchain"],
 )
 
 diff_test(
@@ -74,8 +74,8 @@ genrule(
         $(NODE_PATH) \\
         ./$(execpath :require_acorn_js) \\
         $@""",
-    toolchains = ["@nodejs_toolchains//:resolved_toolchain"],
-    tools = ["@nodejs_toolchains//:resolved_toolchain"],
+    toolchains = ["@rules_nodejs//nodejs:current_node_toolchain"],
+    tools = ["@rules_nodejs//nodejs:current_node_toolchain"],
 )
 
 diff_test(

examples/genrule/BUILD.bazel

@@ -288,7 +288,7 @@ _ATTRS = {
         """,
     ),
     "node_toolchain": attr.label(
-        doc = """The Node.js toolchain to use for this target.
+        doc = """The Node.js runtime toolchain to use for this target.
 
         See https://bazel-contrib.github.io/rules_nodejs/Toolchains.html
 
@@ -490,7 +490,7 @@ def _create_launcher(ctx, log_prefix_rule_set, log_prefix_rule, fixed_args = [],
     if ctx.attr.node_toolchain:
         nodeinfo = ctx.attr.node_toolchain[platform_common.ToolchainInfo].nodeinfo
     else:
-        nodeinfo = ctx.toolchains["@rules_nodejs//nodejs:toolchain_type"].nodeinfo
+        nodeinfo = ctx.toolchains["@rules_nodejs//nodejs:runtime_toolchain_type"].nodeinfo
 
     directory_path_provider = DirectoryPathInfo if DirectoryPathInfo in ctx.attr.entry_point else _LegacyDirectoryPathInfo
     if directory_path_provider in ctx.attr.entry_point:
@@ -612,7 +612,7 @@ js_binary_lib = struct(
     toolchains = [
         # TODO: on Windows this toolchain is never referenced
         "@bazel_tools//tools/sh:toolchain_type",
-        "@rules_nodejs//nodejs:toolchain_type",
+        "@rules_nodejs//nodejs:runtime_toolchain_type",
     ] + COPY_FILE_TO_BIN_TOOLCHAINS,
 )
 

js/private/js_binary.bzl

@@ -408,7 +408,7 @@ else {
         transitive = [files],
     )
 
-    nodeinfo = ctx.attr._current_node[platform_common.ToolchainInfo].nodeinfo
+    nodeinfo = ctx.toolchains["@rules_nodejs//nodejs:toolchain_type"].nodeinfo
     node_exec = nodeinfo.node
     ctx.actions.run(
         inputs = inputs,
@@ -418,6 +418,7 @@ else {
         executable = node_exec,
         progress_message = "Computing Layer Groups %{label}",
         mnemonic = "JsImageLayerGroups",
+        toolchain = "@rules_nodejs//nodejs:toolchain_type",
     )
 
     return expected_layer_groups
@@ -620,10 +621,6 @@ js_image_layer_lib = struct(
             default = "//js/private:js_image_layer.mjs",
             allow_single_file = True,
         ),
-        "_current_node": attr.label(
-            default = "@nodejs_toolchains//:resolved_toolchain",
-            cfg = "exec",
-        ),
         "binary": attr.label(
             mandatory = True,
             cfg = _js_image_layer_transition,

js/private/js_image_layer.bzl

@@ -85,5 +85,5 @@ sh_test(
         "@nodejs_linux_amd64//:node_files",
         "@nodejs_linux_arm64//:node_files",
     ],
-    toolchains = ["@nodejs_toolchains//:resolved_toolchain"],
+    toolchains = ["@rules_nodejs//nodejs:current_node_runtime"],
 )