Skip to content

Commit c4a21c7

Browse files
committed
test: remove stale TODO
1 parent d5c919d commit c4a21c7

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

examples/npm_deps/BUILD.bazel

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,6 @@ js_test(
6262
":node_modules/@rollup/plugin-commonjs",
6363
":node_modules/mobx-react",
6464
":node_modules/react",
65-
# TODO: fix this test so we test a peer dependency without requiring it as a direct
66-
# dependency https://github.com/aspect-build/rules_js/issues/92
67-
":node_modules/rollup",
6865
],
6966
entry_point = "peer_test.js",
7067
)

examples/npm_deps/peer_test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
const cjs = require('@rollup/plugin-commonjs/package.json')
2-
const rollup = require('rollup')
32
const assert = require('assert')
43
const react = require('react')
54
const mobx = require('mobx-react/package.json')
65
assert.equal(react.version, '17.0.2')
76
assert.equal(mobx.version, '7.3.0')
87
assert.equal(cjs.version, '21.1.0')
9-
assert.equal(rollup.VERSION, '2.70.2')
8+
9+
// Ensure the main package with peer dependencies works too
10+
require('@rollup/plugin-commonjs')

0 commit comments

Comments
 (0)