test: importing of dev alias of a non-dev dep (#2482) (#2483)

#2482 is worth adding to
`main`

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases
- New test cases added

Author: jbedard

.aspect/rules/external_repository_action_cache/npm_translate_lock_LTE4Nzc1MDcwNjU=

@@ -7,8 +7,8 @@ examples/js_lib_pkg/a/package.json=740602849
 examples/js_lib_pkg/b/package.json=-561926249
 examples/linked_consumer/package.json=-1109186228
 examples/linked_empty_node_modules/package.json=-1039372825
-examples/linked_lib/package.json=1590632845
-examples/linked_pkg/package.json=-726181961
+examples/linked_lib/package.json=-1249214784
+examples/linked_pkg/package.json=344249322
 examples/macro/package.json=857146175
 examples/nextjs/package.json=886845923
 examples/npm_deps/package.json=-929156430
@@ -33,5 +33,5 @@ npm/private/test/vendored/is-odd/package.json=1041695223
 npm/private/test/vendored/lodash-4.17.21.tgz=-1206623349
 npm/private/test/vendored/semver-max/package.json=578664053
 package.json=1085031407
-pnpm-lock.yaml=1843591580
+pnpm-lock.yaml=-335525060
 pnpm-workspace.yaml=-2039776064

examples/linked_consumer/test_pkg_deps_linked.js

@@ -28,11 +28,35 @@ if (e == null) {
 
 let e2 = null
 try {
-    testLib2.importDevDep()
+    testLib.importAliasedDevDep()
 } catch (ex) {
     e2 = ex
 }
 if (e2 == null) {
+    throw new Error('devDependency should NOT be available')
+} else {
+    console.log('devDependency not available')
+}
+
+let e3 = null
+try {
+    testLib2.importDevDep()
+} catch (ex) {
+    e3 = ex
+}
+if (e3 == null) {
+    console.error(
+        'BUG: devDependency should NOT be available when linking js_library()'
+    )
+}
+
+let e4 = null
+try {
+    testLib2.importAliasedDevDep()
+} catch (ex) {
+    e4 = ex
+}
+if (e4 == null) {
     console.error(
         'BUG: devDependency should NOT be available when linking js_library()'
     )

examples/linked_lib/index.js

@@ -1,3 +1,4 @@
 exports.importDep = () => require('@aspect-test/e')
 exports.importDevDep = () => require('@aspect-test/f')
 exports.importAliasedDep = () => require('alias-e')
+exports.importAliasedDevDep = () => require('@aspect-test/e-dev')

examples/linked_lib/package.json

@@ -7,6 +7,7 @@
     },
     "devDependencies": {
         "@types/node": "18.13.0",
+        "@aspect-test/e-dev": "npm:@aspect-test/e",
         "@aspect-test/f": "1.0.0"
     }
 }

examples/linked_pkg/BUILD.bazel

@@ -11,6 +11,7 @@ js_library(
     visibility = ["//visibility:public"],
     deps = [
         ":node_modules/@aspect-test/e",
+        ":node_modules/@aspect-test/e-dev",
         ":node_modules/@aspect-test/f",
         ":node_modules/@types/node",
         ":node_modules/alias-e",

examples/linked_pkg/index.js

@@ -1,3 +1,4 @@
 exports.importDep = () => require('@aspect-test/e')
 exports.importDevDep = () => require('@aspect-test/f')
 exports.importAliasedDep = () => require('alias-e')
+exports.importAliasedDevDep = () => require('@aspect-test/e-dev')

examples/linked_pkg/package.json

@@ -7,6 +7,7 @@
     },
     "devDependencies": {
         "@types/node": "18.13.0",
+        "@aspect-test/e-dev": "npm:@aspect-test/e",
         "@aspect-test/f": "1.0.0"
     }
 }