feat: set default node version to latest v24 LTS release

Author: jbedard

MODULE.bazel

@@ -117,7 +117,11 @@ use_repo(node_dev, "node24_linux_arm64")
 use_repo(node_dev, "node24_linux_s390x")
 use_repo(node_dev, "node24_linux_ppc64le")
 use_repo(node_dev, "node24_windows_amd64")
-node_dev.toolchain(node_version = "20.19.1")
+
+# default name+version
+node_dev.toolchain()
+
+# additional custom name+versions
 node_dev.toolchain(
     name = "node20",
     node_version = "20.19.5",

js/private/test/image/checksum_test.expected

@@ -1,4 +1,4 @@
-65824fa536872fb5167484fb8b497d2c6494de1cb324857178ab54acedc1b2e1  js/private/test/image/cksum_node
+c01c8dc7e9a202ec0f0e1bd4e48afcdfc4c71c27ebe186275d525eeb199b29ac  js/private/test/image/cksum_node
 052600f3a82ab6a4cc12cab7384971c960f9c589fdbfcf21bca563c36ff7d16e  js/private/test/image/cksum_package_store_3p
 971f291232f3ab63aff37fb66c96fbf0eddc05ea9564b9673d0d2c9bfe958994  js/private/test/image/cksum_package_store_1p
 febf95a6d554c9bda3f0515bfd5ef273ac67d31c231d8162beaef8c4b7bc72f3  js/private/test/image/cksum_node_modules

js/private/test/image/custom_layers_nomatch_test_node.listing

@@ -14,4 +14,4 @@ drwxr-xr-x  0 0      0           0 Jan  1  1970 ./app/js/private/test/image/bin.
 drwxr-xr-x  0 0      0           0 Jan  1  1970 ./app/js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/
 drwxr-xr-x  0 0      0           0 Jan  1  1970 ./app/js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/
 drwxr-xr-x  0 0      0           0 Jan  1  1970 ./app/js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/
--r-xr-xr-x  0 0      0    99831240 Jan  1  1970 ./app/js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/node
+-r-xr-xr-x  0 0      0    97607264 Jan  1  1970 ./app/js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/node

js/private/test/image/custom_owner_test_node.listing

@@ -13,4 +13,4 @@ drwxr-xr-x  0 100    0           0 Jan  1  1970 ./js/private/test/image/bin.runf
 drwxr-xr-x  0 100    0           0 Jan  1  1970 ./js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/
 drwxr-xr-x  0 100    0           0 Jan  1  1970 ./js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/
 drwxr-xr-x  0 100    0           0 Jan  1  1970 ./js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/
--r-xr-xr-x  0 100    0    99831240 Jan  1  1970 ./js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/node
+-r-xr-xr-x  0 100    0    97607264 Jan  1  1970 ./js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/node

js/private/test/image/default_test_node.listing

@@ -13,4 +13,4 @@ drwxr-xr-x  0 0      0           0 Jan  1  1970 ./js/private/test/image/bin.runf
 drwxr-xr-x  0 0      0           0 Jan  1  1970 ./js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/
 drwxr-xr-x  0 0      0           0 Jan  1  1970 ./js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/
 drwxr-xr-x  0 0      0           0 Jan  1  1970 ./js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/
--r-xr-xr-x  0 0      0    99831240 Jan  1  1970 ./js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/node
+-r-xr-xr-x  0 0      0    97607264 Jan  1  1970 ./js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/node

js/private/test/image/non_ascii/custom_layer_groups_test_node.listing

@@ -14,4 +14,4 @@ drwxr-xr-x  0 0      0           0 Jan  1  1970 ./app/js/private/test/image/non_
 drwxr-xr-x  0 0      0           0 Jan  1  1970 ./app/js/private/test/image/non_ascii/bin2.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/
 drwxr-xr-x  0 0      0           0 Jan  1  1970 ./app/js/private/test/image/non_ascii/bin2.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/
 drwxr-xr-x  0 0      0           0 Jan  1  1970 ./app/js/private/test/image/non_ascii/bin2.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/
--r-xr-xr-x  0 0      0    99831240 Jan  1  1970 ./app/js/private/test/image/non_ascii/bin2.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/node
+-r-xr-xr-x  0 0      0    97607264 Jan  1  1970 ./app/js/private/test/image/non_ascii/bin2.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/node

js/private/test/image/regex_edge_cases_test_node.listing

@@ -14,4 +14,4 @@ drwxr-xr-x  0 0      0           0 Jan  1  1970 ./app/js/private/test/image/bin.
 drwxr-xr-x  0 0      0           0 Jan  1  1970 ./app/js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/
 drwxr-xr-x  0 0      0           0 Jan  1  1970 ./app/js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/
 drwxr-xr-x  0 0      0           0 Jan  1  1970 ./app/js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/
--r-xr-xr-x  0 0      0    99831240 Jan  1  1970 ./app/js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/node
+-r-xr-xr-x  0 0      0    97607264 Jan  1  1970 ./app/js/private/test/image/bin.runfiles/rules_nodejs~~node~nodejs_linux_amd64/bin/nodejs/bin/node

js/private/test/node-patches/BUILD.bazel

@@ -21,6 +21,7 @@ CJS_TESTS = [
 
 # Multiple node toolchains for testing across versions
 TOOLCHAINS_NAMES = [
+    "nodejs",
     "node20",
     "node22",
     "node24",

js/toolchains.bzl

@@ -9,11 +9,16 @@ load(
     _register_jq_toolchains = "register_jq_toolchains",
     _register_yq_toolchains = "register_yq_toolchains",
 )
-load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains", _DEFAULT_NODE_REPOSITORY = "DEFAULT_NODE_REPOSITORY", _DEFAULT_NODE_VERSION = "DEFAULT_NODE_VERSION")
+load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains", _DEFAULT_NODE_REPOSITORY = "DEFAULT_NODE_REPOSITORY", _NODE_VERSIONS = "NODE_VERSIONS")
 load("@tar.bzl//tar:extensions.bzl", _tar_create_repositories = "create_repositories")
 
 DEFAULT_NODE_REPOSITORY = _DEFAULT_NODE_REPOSITORY
-DEFAULT_NODE_VERSION = _DEFAULT_NODE_VERSION
+DEFAULT_NODE_VERSION = [
+    # 16.18.1-windows_amd64 -> 16.18.1
+    v.split("-")[0]
+    for v in _NODE_VERSIONS.keys()
+    if v.startswith("24.")
+][-1]  # Versions are sorted increasing, so last one is the latest version
 
 def rules_js_register_toolchains(
         node_download_auth = {},