Skip to content

Commit ddec036

Browse files
authored
fix: share single package store entry accross all aliases to local projects (#2474)
Multiple aliases referring to the same local workspace project should share a single entry in the package store. ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases - Manual testing; see diff of snapshot files
1 parent 6d43623 commit ddec036

File tree

10 files changed

+170
-272
lines changed

10 files changed

+170
-272
lines changed

e2e/pnpm_lockfiles/lockfile-test.bzl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ def lockfile_test(npm_link_all_packages, name = None):
138138
":.aspect_rules_js/node_modules/@[email protected]",
139139
":.aspect_rules_js/node_modules/@scoped+c@file+..+projects+c_at_scoped_b_projects%sb" % ("_" if lock_version == "v54" else "+"), # is declared as a file: instead of link:
140140
":.aspect_rules_js/node_modules/@[email protected]",
141-
":.aspect_rules_js/node_modules/[email protected]",
142141

143142
# file: 4.17.21.tgz tarbal
144143
":node_modules/lodash",

e2e/pnpm_lockfiles/v101/snapshots/defs.bzl

Lines changed: 32 additions & 60 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/pnpm_lockfiles/v90/snapshots/defs.bzl

Lines changed: 32 additions & 60 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

e2e/pnpm_workspace/app/b/BUILD.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,6 @@ build_test(
3636
targets = [
3737
":node_modules/@lib/b",
3838
":node_modules/@lib/b_alias",
39-
"//:.aspect_rules_js/node_modules/@lib+b_alias@0.0.0",
39+
"//:.aspect_rules_js/node_modules/@lib+b@0.0.0",
4040
],
4141
)

0 commit comments

Comments
 (0)