refactor: stop reading pnpm_lock from label_store (#2395)

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

Author: dzbarsky

npm/private/npm_translate_lock.bzl

@@ -162,7 +162,6 @@ See https://github.com/aspect-build/rules_js/issues/1445
 
     generate_repository_files(
         rctx,
-        state.label_store.label("pnpm_lock"),
         importers,
         packages,
         state.patched_dependencies(),

npm/private/npm_translate_lock_generate.bzl

@@ -82,9 +82,9 @@ _PACKAGE_JSON_BZL_FILENAME = "package_json.bzl"
 _RESOLVED_JSON_FILENAME = "resolved.json"
 
 # buildifier: disable=function-docstring
-def generate_repository_files(rctx, pnpm_lock_label, importers, packages, patched_dependencies, only_built_dependencies, root_package, default_registry, npm_registries, npm_auth, link_workspace):
+def generate_repository_files(rctx, importers, packages, patched_dependencies, only_built_dependencies, root_package, default_registry, npm_registries, npm_auth, link_workspace):
     # empty line after bzl docstring since buildifier expects this if this file is vendored in
-    generated_by_prefix = "\"\"\"@generated by npm_translate_lock(name = \"{}\", pnpm_lock = \"{}\")\"\"\"\n".format(helpers.to_apparent_repo_name(rctx.name), str(pnpm_lock_label))
+    generated_by_prefix = "\"\"\"@generated by npm_translate_lock(name = \"{}\", pnpm_lock = \"{}\")\"\"\"\n".format(helpers.to_apparent_repo_name(rctx.name), str(rctx.attr.pnpm_lock))
 
     npm_imports = helpers.get_npm_imports(importers, packages, patched_dependencies, only_built_dependencies, root_package, rctx.name, rctx.attr, rctx.attr.lifecycle_hooks, rctx.attr.lifecycle_hooks_execution_requirements, rctx.attr.lifecycle_hooks_use_default_shell_env, npm_registries, default_registry, npm_auth)
 
@@ -270,7 +270,7 @@ def npm_link_all_packages(name = "node_modules", imported_links = [], prod = Tru
             defs_bzl_file = "@{}//:{}".format(rctx.name, rctx.attr.defs_bzl_filename),
             link_packages_comma_separated = "\"'\" + \"', '\".join(_LINK_PACKAGES) + \"'\"" if len(link_packages) else "\"\"",
             root_package = root_package,
-            pnpm_lock_label = pnpm_lock_label,
+            pnpm_lock_label = rctx.attr.pnpm_lock,
         ),
     ]
 
@@ -589,21 +589,20 @@ def npm_link_all_packages(name = "node_modules", imported_links = [], prod = Tru
         rctx_files[rctx.attr.repositories_bzl_filename] = _generate_repositories(
             rctx,
             npm_imports,
-            pnpm_lock_label,
             link_workspace,
         )
 
     for filename, contents in rctx_files.items():
         rctx.file(filename, generated_by_prefix + "\n" + "\n".join(contents))
 
-def _generate_repositories(rctx, npm_imports, pnpm_lock_label, link_workspace):
+def _generate_repositories(rctx, npm_imports, link_workspace):
     repositories_bzl = []
 
     if len(npm_imports) > 0:
         repositories_bzl.append("""load("@aspect_rules_js//npm:repositories.bzl", "npm_import")""")
         repositories_bzl.append("")
 
-    repositories_bzl.append("# Generated npm_import repository rules corresponding to npm packages in {}".format(str(pnpm_lock_label)))
+    repositories_bzl.append("# Generated npm_import repository rules corresponding to npm packages in {}".format(str(rctx.attr.pnpm_lock)))
     repositories_bzl.append("# buildifier: disable=function-docstring")
     repositories_bzl.append("def npm_repositories():")
     if len(npm_imports) == 0:

npm/private/npm_translate_lock_state.bzl

@@ -45,13 +45,13 @@ WARNING: `update_pnpm_lock` attribute in `npm_translate_lock(name = "{rctx_name}
         # labels only needed when updating the pnpm lock file
         _init_update_labels(priv, rctx, attr, label_store)
 
-    _init_link_workspace(priv, rctx, attr, label_store)
+    _init_link_workspace(priv, attr, label_store)
 
     # parse the pnpm lock file incase since we need the importers list for additional init
     # TODO(windows): utils.exists is not yet support on Windows
     pnpm_lock_exists = is_windows or utils.exists(rctx, label_store.path("pnpm_lock"))
     if pnpm_lock_exists:
-        _load_lockfile(priv, rctx, attr, label_store)
+        _load_lockfile(priv, rctx, label_store)
         _init_patched_dependencies_labels(priv, rctx, attr, label_store)
 
     # May depend on lockfile state
@@ -167,12 +167,10 @@ def _init_patches_labels(priv, _, attr, label_store):
 ################################################################################
 def _init_patched_dependencies_labels(priv, _, attr, label_store):
     # Read patches from pnpm-lock.yaml `patchedDependencies`
-    patches = []
-    for patch_info in priv["patched_dependencies"].values():
-        patches.append("//%s:%s" % (label_store.label("pnpm_lock").package, patch_info.get("path")))
-
-    # Convert patch label strings to labels
-    patches = [attr.pnpm_lock.relative(p) for p in patches]
+    patches = [
+        attr.pnpm_lock.same_package_label(patch_info["path"])
+        for patch_info in priv["patched_dependencies"].values()
+    ]
 
     for i, d in enumerate(patches):
         label_store.add("patches_{}".format(i + priv["num_patches"]), d)
@@ -185,7 +183,7 @@ def _init_importer_labels(priv, label_store):
         label_store.add_sibling("lock", "package_json_{}".format(i), paths.join(p, PACKAGE_JSON_FILENAME))
 
 ################################################################################
-def _init_link_workspace(priv, _, attr, label_store):
+def _init_link_workspace(priv, attr, label_store):
     # initialize link_workspace either from pnpm_lock label or from override
     priv["link_workspace"] = attr.link_workspace if attr.link_workspace else label_store.label("pnpm_lock").repo_name
 
@@ -283,7 +281,7 @@ def _copy_update_input_files(priv, rctx, attr, label_store):
 ################################################################################
 # we can derive input files that should be specified but are not and copy these over; we warn the user when we do this
 def _copy_unspecified_input_files(priv, rctx, attr, label_store):
-    pnpm_lock_label = label_store.label("pnpm_lock")
+    pnpm_lock_label = attr.pnpm_lock
 
     # pnpm-workspace.yaml
     pnpm_workspace_key = "pnpm_workspace"
@@ -479,7 +477,7 @@ WARNING: Cannot determine home directory in order to load home `.npmrc` file in
         _load_npmrc(priv, rctx, home_npmrc_path)
 
 ################################################################################
-def _load_lockfile(priv, rctx, _, label_store):
+def _load_lockfile(priv, rctx, label_store):
     importers = {}
     packages = {}
     patched_dependencies = {}