refactor: mark npm_import(dev) as deprecated

jbedard · jbedard · commit f46245e3e3e6 · 2025-11-04T17:56:30.000-08:00
diff --git a/docs/npm_import.md b/docs/npm_import.md
diff --git a/npm/private/npm_import.bzl b/npm/private/npm_import.bzl
@@ -1273,6 +1273,11 @@ def npm_import(
 
         dev: Whether this npm package is a dev dependency
 
+            DEPRECATED: this field is deprecated and will be removed in a future release.
+
+            A package should be marked as a dev dependency as part of the dependency declaration,
+            not as part of the package definition or import.
+
         exclude_package_contents: List of glob patterns to exclude from the linked package.
 
             This is useful for excluding files that are not needed in the linked package.
diff --git a/npm/private/npm_package_store_info.bzl b/npm/private/npm_package_store_info.bzl
@@ -14,6 +14,6 @@ NpmPackageStoreInfo = provider(
         "package_store_directory": "the TreeArtifact of this npm package's package store location",
         "files": "depset of files that are part of the npm package",
         "transitive_files": "depset of the files that are part of the npm package and its transitive deps",
-        "dev": "whether or not this npm package is a dev dependency",
+        "dev": "DEPRECATED: whether or not this npm package is a dev dependency",
     },
 )

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,6 @@ NpmPackageStoreInfo = provider(`
`14`	`14`	`"package_store_directory": "the TreeArtifact of this npm package's package store location",`
`15`	`15`	`"files": "depset of files that are part of the npm package",`
`16`	`16`	`"transitive_files": "depset of the files that are part of the npm package and its transitive deps",`
`17`		`- "dev": "whether or not this npm package is a dev dependency",`
	`17`	`+ "dev": "DEPRECATED: whether or not this npm package is a dev dependency",`
`18`	`18`	`},`
`19`	`19`	`)`