Cleanup

Author: martin4861

example/MODULE.bazel

@@ -181,6 +181,8 @@ register_toolchains("@ruby_toolchains//:all")
 # Download cppcheck premium tar files for different platforms
 http_archive = use_repo_rule("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
+# Even though cppcheckpremium is downloaded, it behaves like the free version, if we do not
+# provide a cppcheck.cfg file (see cppcheck.BUILD file) and license key.
 http_archive(
     name = "cppcheck_linux",
     build_file = "//tools/lint:cppcheck.BUILD",

example/test/lint_test.bats

@@ -29,7 +29,7 @@ EOF
 	# PMD
 	echo <<"EOF" | assert_output --partial
 * file: src/Foo.java
-    src:  Foo.java:9:9
+    src:  Foo.jav fa:9:9
     rule: FinalizeOverloaded
     msg:  Finalize methods should not be overloaded
     code: protected void finalize(int a) {}

example/tools/lint/cppcheck.BUILD

@@ -1,4 +1,4 @@
-# BUILD file for cppcheck premium external repository
+# BUILD file for cppcheck external repository
 
 package(default_visibility = ["//visibility:public"])
 

example/tools/lint/cppcheck_wrapper.sh.tpl

@@ -6,7 +6,7 @@ SCRIPT_DIR="$(dirname "$0")"
 RUNFILES_DIR="$SCRIPT_DIR/cppcheck.runfiles"
 
 # Find the cppcheck binary in the runfiles directory
-# It will be under one of the cppcheck_premium_* directories
+# It will be under one of the cppcheck_* directories
 # Note: cppcheck may be a symlink, so don't use -type f
 CPPCHECK_BINARY=$(find "$RUNFILES_DIR" -name "cppcheck" \( -type f -o -type l \) 2>/dev/null | head -n1)
 

lint/cppcheck.bzl

@@ -158,7 +158,7 @@ def lint_cppcheck_aspect(binary, verbose = False):
             ```bash
             #!/bin/bash
 
-            ~/.local/bin/cppcheckpremium/cppcheck \
+            ~/.local/bin/cppcheck/cppcheck \
                 --check-level=exhaustive \
                 --enable=warning,style,performance,portability,information \
                 "$@"