Skip to content

Commit 94982ea

Browse files
authored
feat: start testing on Bazel 8 (#401)
* feat: start testing on Bazel 8 * chore: disable a stardoc diff test on bazel 7
1 parent 431a36a commit 94982ea

File tree

4 files changed

+7
-10
lines changed

4 files changed

+7
-10
lines changed

.github/workflows/ci.yaml

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,18 +18,11 @@ concurrency:
1818

1919
jobs:
2020
bazel-test:
21-
uses: bazel-contrib/.github/.github/workflows/bazel.yaml@v6
21+
uses: bazel-contrib/.github/.github/workflows/bazel.yaml@bazel8
2222
with:
2323
folders: '[".", "example"]'
2424
# Don't try for Windows support yet.
2525
exclude_windows: true
26-
# Root module is bzlmod-only and uses newer stardoc that requires Bazel 7.
27-
# Example uses incompatible_enable_proto_toolchain_resolution
28-
exclude: |
29-
[
30-
{"bzlmodEnabled": false, "folder": "."},
31-
{"bazelversion": "6.4.0"}
32-
]
3326

3427
integration-test:
3528
runs-on: ubuntu-latest

MODULE.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ bazel_dep(name = "aspect_bazel_lib", version = "2.7.7")
1212
# Minimum version needs 'chore: bump bazel-lib to 2.0 by @alexeagle in #1311'
1313
# to allow users on bazel-lib 2.0
1414
bazel_dep(name = "aspect_rules_js", version = "1.40.0")
15+
bazel_dep(name = "bazel_features", version = "1.18.0")
1516
bazel_dep(name = "bazel_skylib", version = "1.4.2")
1617
bazel_dep(name = "platforms", version = "0.0.7")
1718
bazel_dep(name = "rules_multirun", version = "0.9.0")

docs/BUILD.bazel

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# This load statement must be in the docs/ package rather than anything users depend on
22
# so that the dependency on stardoc doesn't leak to them.
33
load("@aspect_bazel_lib//lib:docs.bzl", "stardoc_with_diff_test", "update_docs")
4+
load("@bazel_features//private:util.bzl", "lt")
45

56
stardoc_with_diff_test(
67
name = "lint_test",
@@ -35,6 +36,8 @@ stardoc_with_diff_test(
3536
stardoc_with_diff_test(
3637
name = "format",
3738
bzl_library_target = "//format:defs",
39+
# See https://github.com/bazel-contrib/bazel_features/pull/75
40+
target_compatible_with = ["@platforms//:incompatible"] if lt("8.0.0-pre.20240911.1") else [],
3841
)
3942

4043
stardoc_with_diff_test(

docs/format.md

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)