Commit 84f5644
authored
tweak(py_venv): Don't modifying shell flags in
### Changes are visible to end-users: yes
When creating a virtual environment, the `activate` script no longer
modifies bash flags. These flags were added in
#576 (v1.6.0) (note, they
don't appear in the scripts that Python's `venv` module generates).
<!-- If no, please delete this section. -->
- Searched for relevant documentation and updated as needed: yes
(behaviour is not documented)
- Breaking change (forces users to change their own code or config):no
- Suggested release notes appear below: yes/no
### Test plan
- Manual testing; please provide instructions so we can reproduce:
Potentially, users could have some tests running the following commands.
The new flags introduced in
#576 broke this kind of
tests:
```sh
#!/usr/bin/env bash
set -euo pipefail
# Create a virtualenvironment
bazel run //:venv
# Activate it (previous it was setting +e flag)
source .venv/bin/activate
# Some failing test -- users expects the script to end and fail here
false
# Some other command that doesn't fail
true
# !!!! Script returns 0 !!!!
```activate (#669)1 parent a25b2cb commit 84f5644
File tree
3 files changed
+2
-6
lines changed- py
- tests/py_venv_image_layer
- tools/py/src
3 files changed
+2
-6
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2510 | 2510 | | |
2511 | 2511 | | |
2512 | 2512 | | |
2513 | | - | |
| 2513 | + | |
2514 | 2514 | | |
2515 | 2515 | | |
2516 | 2516 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2491 | 2491 | | |
2492 | 2492 | | |
2493 | 2493 | | |
2494 | | - | |
| 2494 | + | |
2495 | 2495 | | |
2496 | 2496 | | |
2497 | 2497 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | 3 | | |
6 | 4 | | |
7 | 5 | | |
| |||
84 | 82 | | |
85 | 83 | | |
86 | 84 | | |
87 | | - | |
88 | | - | |
0 commit comments