refactor: don't default imports to current folder (#367)

Author: alexeagle

docs/rules.md

@@ -14,12 +14,12 @@ py_pytest_main = _py_pytest_main
 py_venv = _py_venv
 py_binary_rule = _py_binary
 py_test_rule = _py_test
-py_library_rule = _py_library
-py_unpacked_wheel_rule = _py_unpacked_wheel
+py_library = _py_library
+py_unpacked_wheel = _py_unpacked_wheel
 
 resolutions = _resolutions
 
-def _py_binary_or_test(name, rule, srcs, main, imports, deps = [], resolutions = {}, **kwargs):
+def _py_binary_or_test(name, rule, srcs, main, deps = [], resolutions = {}, **kwargs):
     # Compatibility with rules_python, see docs in py_executable.bzl
     main_target = "_{}.find_main".format(name)
     determine_main(
@@ -34,7 +34,6 @@ def _py_binary_or_test(name, rule, srcs, main, imports, deps = [], resolutions =
         name = name,
         srcs = srcs,
         main = main_target,
-        imports = imports,
         deps = deps,
         resolutions = resolutions,
         **kwargs
@@ -43,17 +42,17 @@ def _py_binary_or_test(name, rule, srcs, main, imports, deps = [], resolutions =
     _py_venv(
         name = "{}.venv".format(name),
         deps = deps,
-        imports = imports,
+        imports = kwargs.get("imports"),
         resolutions = resolutions,
         tags = ["manual"],
         testonly = kwargs.get("testonly", False),
     )
 
-def py_binary(name, srcs = [], main = None, imports = ["."], **kwargs):
-    """Wrapper macro for [`py_binary_rule`](#py_binary_rule), setting a default for imports.
+def py_binary(name, srcs = [], main = None, **kwargs):
+    """Wrapper macro for [`py_binary_rule`](#py_binary_rule).
 
-    It also creates a virtualenv to constrain the interpreter and packages used at runtime,
-    you can `bazel run [name].venv` to produce this, then use it in the editor.
+    Creates a virtualenv to constrain the interpreter and packages used at runtime.
+    Users can `bazel run [name].venv` to produce this, then use it in the editor.
 
     Args:
         name: Name of the rule.
@@ -62,7 +61,6 @@ def py_binary(name, srcs = [], main = None, imports = ["."], **kwargs):
             Like rules_python, this is treated as a suffix of a file that should appear among the srcs.
             If absent, then "[name].py" is tried. As a final fallback, if the srcs has a single file,
             that is used as the main.
-        imports: List of import paths to add for this binary.
         **kwargs: additional named parameters to the py_binary_rule.
     """
 
@@ -72,32 +70,11 @@ def py_binary(name, srcs = [], main = None, imports = ["."], **kwargs):
     if resolutions:
         resolutions = resolutions.to_label_keyed_dict()
 
-    _py_binary_or_test(name = name, rule = _py_binary, srcs = srcs, main = main, imports = imports, resolutions = resolutions, **kwargs)
+    _py_binary_or_test(name = name, rule = _py_binary, srcs = srcs, main = main, resolutions = resolutions, **kwargs)
 
-def py_test(name, main = None, srcs = [], imports = ["."], **kwargs):
+def py_test(name, main = None, srcs = [], **kwargs):
     "Identical to py_binary, but produces a target that can be used with `bazel test`."
 
     # Ensure that any other targets we write will be testonly like the py_test target
     kwargs["testonly"] = True
-    _py_binary_or_test(name = name, rule = _py_test, srcs = srcs, main = main, imports = imports, **kwargs)
-
-def py_library(name, imports = ["."], **kwargs):
-    """Wrapper macro for the [py_library_rule](./py_library_rule), supporting virtual deps.
-
-    Args:
-        name: Name for this rule.
-        imports: List of import paths to add for this library.
-        **kwargs: Additional named parameters to py_library_rule.
-    """
-
-    _py_library(name = name, imports = imports, **kwargs)
-
-def py_unpacked_wheel(name, **kwargs):
-    """Wrapper macro for the [py_unpacked_wheel_rule](#py_unpacked_wheel_rule), setting a defaults.
-
-    Args:
-        name: Name of this rule.
-        **kwargs: Additional named parameters to py_unpacked_wheel_rule.
-    """
-
-    _py_unpacked_wheel(name = name, **kwargs)
+    _py_binary_or_test(name = name, rule = _py_test, srcs = srcs, main = main, **kwargs)

py/defs.bzl

@@ -214,6 +214,7 @@ _attrs = dict({
     ),
     "imports": attr.string_list(
         doc = "List of import directories to be added to the PYTHONPATH.",
+        default = [],
     ),
     "resolutions": attr.label_keyed_string_dict(
         doc = "FIXME",