fix(venv_link): Correct name argument (#601)

Fixes #598.

---

### Changes are visible to end-users: yes

- Searched for relevant documentation and updated as needed: yes
- Breaking change (forces users to change their own code or config): no
- Suggested release notes appear below: yes

Repairs an issue which caused the `venv_name` parameter to produce
errors.

### Test plan

- Tests added

Author: arrdem

docs/venv.md

@@ -100,6 +100,14 @@ fi
 # Smoke test
 bazel "--output_base=$OUTPUT_BASE" test --test_output=streamed //...
 
+#############
+# Smoke test py_venv_link
+bazel "--output_base=$OUTPUT_BASE" run //src:venv
+if ! [ -L ./.venv_named ]; then
+  >&2 echo "ERROR: The named venv target failed to respect venv_name"
+  exit 1
+fi
+
 #############
 # Demonstrate that as configured we're fully on prebuilt toolchains even for crossbuilds
 OUTPUT_BASE=$(mktemp -d)

e2e/use_release/minimal_download_test.sh

@@ -1,4 +1,4 @@
-load("@aspect_rules_py//py:defs.bzl", "py_binary", "py_test")
+load("@aspect_rules_py//py:defs.bzl", "py_binary", "py_test", "py_venv")
 
 py_binary(
     name = "main",
@@ -9,6 +9,15 @@ py_binary(
     main = "__main__.py",
 )
 
+py_venv(
+    name = "venv",
+    srcs = [
+        "__init__.py",
+        "__main__.py",
+    ],
+    venv_name = ".venv_named",
+)
+
 py_test(
     name = "test",
     srcs = ["my_test.py"],

e2e/use_release/src/BUILD.bazel

@@ -378,15 +378,15 @@ py_venv = _wrap_with_debug(_py_venv)
 py_venv_binary = _wrap_with_debug(_py_venv_binary)
 py_venv_test = _wrap_with_debug(_py_venv_test)
 
-def py_venv_link(venv_name = None, **kwargs):
+def py_venv_link(venv_name = None, srcs = [], **kwargs):
     """Build a Python virtual environment and produce a script to link it into the build directory."""
 
     # Note that the binary is already wrapped with debug
     link_script = str(Label("//py/private/py_venv:link.py"))
     kwargs["debug"] = select({Label(":debug_build"): True, "//conditions:default": False})
     py_venv_binary(
-        args = [] + (["--venv-name=" + venv_name] if venv_name else []),
+        args = [] + (["--name=" + venv_name] if venv_name else []),
         main = link_script,
-        srcs = [link_script],
+        srcs = srcs + [link_script],
         **kwargs
     )