Skip to content

Commit 74adfa9

Browse files
authored
fix: Use .cjs for generated webpack config (#169)
This makes it compatible with repos which use ESM
1 parent c4270c9 commit 74adfa9

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

webpack/private/webpack_create_configs.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ def webpack_create_configs(
120120
if entry_points_mandatory and not entry_point and not entry_points:
121121
fail("One of entry_point or entry_points must be specified")
122122

123-
default_config = "%s.webpack.config.js" % name
123+
default_config = "%s.webpack.config.cjs" % name
124124
_create_base_config(
125125
name = "_%s_config" % name,
126126
config_out = default_config,

webpack/tests/create_configs/BUILD.bazel

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,10 @@ webpack_create_configs(
6565
write_source_files(
6666
name = "tests",
6767
files = {
68-
"expected.basic.webpack.js": "basic.webpack.config.js",
69-
"expected.devtool_mode.webpack.js": "devtool_mode.webpack.config.js",
70-
"expected.entry.webpack.js": "entry.webpack.config.js",
71-
"expected.entries.webpack.js": "entries.webpack.config.js",
72-
"expected.chdir.webpack.js": "chdir.webpack.config.js",
68+
"expected.basic.webpack.js": "basic.webpack.config.cjs",
69+
"expected.devtool_mode.webpack.js": "devtool_mode.webpack.config.cjs",
70+
"expected.entry.webpack.js": "entry.webpack.config.cjs",
71+
"expected.entries.webpack.js": "entries.webpack.config.cjs",
72+
"expected.chdir.webpack.js": "chdir.webpack.config.cjs",
7373
},
7474
)

0 commit comments

Comments
 (0)