fix filename for rc versions

aaylward · aaylward · commit a3520e754173 · 2024-11-23T16:17:44.000-05:00
diff --git a/examples/MODULE.bazel b/examples/MODULE.bazel
@@ -19,7 +19,7 @@ protoc = use_extension("@toolchains_protoc//protoc:extensions.bzl", "protoc")
 protoc.toolchain(
     google_protobuf = "com_google_protobuf",
     # Demonstrate overriding the default version
-    version = "v28.0",
+    version = "LATEST",
 )
 use_repo(protoc, "com_google_protobuf", "toolchains_protoc_hub")
 
diff --git a/protoc/private/prebuilt_protoc_toolchain.bzl b/protoc/private/prebuilt_protoc_toolchain.bzl
@@ -29,7 +29,7 @@ def _prebuilt_protoc_repo_impl(rctx):
 
     filename = "{}-{}-{}.zip".format(
         "protoc",
-        release_version.removeprefix("v"),
+        release_version.removeprefix("v").replace("rc", "rc-"),
         rctx.attr.platform,
     )
     url = "https://github.com/protocolbuffers/protobuf/releases/download/{}/{}".format(

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ protoc = use_extension("@toolchains_protoc//protoc:extensions.bzl", "protoc")`
`19`	`19`	`protoc.toolchain(`
`20`	`20`	`google_protobuf = "com_google_protobuf",`
`21`	`21`	`# Demonstrate overriding the default version`
`22`		`- version = "v28.0",`
	`22`	`+ version = "LATEST",`
`23`	`23`	`)`
`24`	`24`	`use_repo(protoc, "com_google_protobuf", "toolchains_protoc_hub")`
`25`	`25`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ def _prebuilt_protoc_repo_impl(rctx):`
`29`	`29`
`30`	`30`	`filename = "{}-{}-{}.zip".format(`
`31`	`31`	`"protoc",`
`32`		`- release_version.removeprefix("v"),`
	`32`	`+ release_version.removeprefix("v").replace("rc", "rc-"),`
`33`	`33`	`rctx.attr.platform,`
`34`	`34`	`)`
`35`	`35`	`url = "https://github.com/protocolbuffers/protobuf/releases/download/{}/{}".format(`