Fix download filename for RC versions #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
approved these changes
Dec 6, 2024
|
Thanks! |
|
@alexeagle was this meant to be part of the 0.3.5 release? I don't see the change there |
|
Oh thank you - I tagged 0.3.5 at the same commit as 0.3.4. Good thing I'm rolling out automation to prevent that mistake in a manual release step! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked PR from #33 (I don't have permission to push to that branch)
fixes #32
What is this?
This PR fixes filename resolution for release candidate version of protoc. RC names like
29.0-rc3have release artifacts with names like29.0-rc-3.... see the release assets for 29.0-rc3 or 28.0-rc2Changes are visible to end-users: no
Test plan
LATEST