Skip to content

Conversation

@adincebic
Copy link
Contributor

Generated BUILD.bazel file does not contain required load statement for proto_library:

load("@rules_proto//proto:defs.bzl", "proto_library")

which results in following error on bazel 8:

ERROR: /private/var/tmp/_bazel_adincebic/1899d14f6acb23e5b475897f501caf4b/external/toolchains_protoc++protoc+toolchains_protoc_hub.osx_aarch_64/BUILD.bazel:13:1: name 'proto_library' is not defined

Not sure if this happens on earlier versions of bazel as this rule might have been vendored similar to rules_android and others.

@CLAassistant
Copy link

CLAassistant commented May 1, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I suspect we'll have to give up on this feature of creating libraries for the well-known-types but you're right this is better.

@alexeagle alexeagle merged commit 836ad82 into aspect-build:main May 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants