fix(instrumentation-express): explicitly depend on used express util packages (#141)

Author: Amir Blum

packages/instrumentation-express/package.json

@@ -36,7 +36,9 @@
     "dependencies": {
         "@opentelemetry/core": "^0.21.0",
         "@opentelemetry/instrumentation": "^0.21.0",
-        "@opentelemetry/semantic-conventions": "^0.21.0"
+        "@opentelemetry/semantic-conventions": "^0.21.0",
+        "parseurl": "~1.3.3",
+        "path-to-regexp": "0.1.7"
     },
     "devDependencies": {
         "@opentelemetry/api": "^0.21.0",

packages/instrumentation-express/src/utils/layer-path.ts

@@ -1,4 +1,5 @@
 import { LayerPath, LayerPathAlternative } from '../types';
+import pathRegexp from 'path-to-regexp';
 import type express from 'express';
 
 const pathStringToDisplayValue = (pathInput: string, options: express.RouterOptions): string => {
@@ -14,8 +15,6 @@ const getLayerPathAlternativeFromFirstArg = (
     pathInput: any,
     options
 ): LayerPathAlternative | LayerPathAlternative[] => {
-    const pathRegexp = require('path-to-regexp');
-
     if (typeof pathInput === 'string') {
         return {
             userSuppliedValue: pathInput,

packages/instrumentation-express/src/utils/route-context.ts

@@ -1,4 +1,5 @@
 import { ExpressConsumedRouteState, LayerPath } from '../types';
+import parseurl from 'parseurl';
 import type express from 'express';
 
 export const getUsedPathFromLayerPath = (
@@ -65,7 +66,6 @@ export const createInitialRouteState = (req: express.Request): ExpressConsumedRo
     // at this point, we have the raw http req object, and not the express req.
     // thus, we cannot call req.path
     // we use parseurl(req).pathname which is exactly what express is doing
-    const parseurl = require('parseurl');
     const path = parseurl(req).pathname;
     return { resolvedRoute: '', remainingRoute: path, configuredRoute: '', params: {} };
 };