move span.end call to after response hook call (#219)

gapodaca-atlassian · Amir Blum · web-flow · commit f66dd5657334 · 2022-05-12T16:25:46.000+03:00
Co-authored-by: Amir Blum &lt;amir@aspecto.io&gt;
diff --git a/packages/instrumentation-mongoose/src/utils.ts b/packages/instrumentation-mongoose/src/utils.ts
@@ -80,8 +80,8 @@ export function handlePromiseResponse(
     responseHook?: MongooseResponseCustomAttributesFunction
 ): any {
     if (!(execResponse instanceof Promise)) {
-        span.end();
         applyResponseHook(span, execResponse, responseHook);
+        span.end();
         return execResponse;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -80,8 +80,8 @@ export function handlePromiseResponse(`
`80`	`80`	`responseHook?: MongooseResponseCustomAttributesFunction`
`81`	`81`	`): any {`
`82`	`82`	`if (!(execResponse instanceof Promise)) {`
`83`		`- span.end();`
`84`	`83`	`applyResponseHook(span, execResponse, responseHook);`
	`84`	`+ span.end();`
`85`	`85`	`return execResponse;`
`86`	`86`	`}`
`87`	`87`