Use DataProtectionProvider.Create instead of manually creating a new data protection provider

Author: kevinchalet

src/Owin.Security.OAuth.Introspection/OAuthIntrospectionMiddleware.cs

@@ -10,7 +10,6 @@
 using Microsoft.AspNetCore.DataProtection;
 using Microsoft.Extensions.Caching.Distributed;
 using Microsoft.Extensions.Caching.Memory;
-using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Microsoft.Owin;
 using Microsoft.Owin.BuilderProperties;
@@ -39,28 +38,17 @@ public OAuthIntrospectionMiddleware(
             }
 
             if (options.DataProtectionProvider == null) {
-                // Create a new DI container and register
-                // the data protection services.
-                var services = new ServiceCollection();
+                // Try to use the application name provided by
+                // the OWIN host as the application discriminator.
+                var discriminator = new AppProperties(app.Properties).AppName;
 
-                services.AddDataProtection(configuration => {
-                    // Try to use the application name provided by
-                    // the OWIN host as the application discriminator.
-                    var discriminator = new AppProperties(app.Properties).AppName;
+                // When an application discriminator cannot be resolved from
+                // the OWIN host properties, generate a temporary identifier.
+                if (string.IsNullOrEmpty(discriminator)) {
+                    discriminator = Guid.NewGuid().ToString();
+                }
 
-                    // When an application discriminator cannot be resolved from
-                    // the OWIN host properties, generate a temporary identifier.
-                    if (string.IsNullOrEmpty(discriminator)) {
-                        discriminator = Guid.NewGuid().ToString();
-                    }
-
-                    configuration.ApplicationDiscriminator = discriminator;
-                });
-
-                var container = services.BuildServiceProvider();
-
-                // Resolve a data protection provider from the services container.
-                options.DataProtectionProvider = container.GetRequiredService<IDataProtectionProvider>();
+                options.DataProtectionProvider = DataProtectionProvider.Create(discriminator);
             }
 
             if (options.AccessTokenFormat == null) {

src/Owin.Security.OAuth.Validation/OAuthValidationMiddleware.cs

@@ -7,7 +7,6 @@
 using System;
 using JetBrains.Annotations;
 using Microsoft.AspNetCore.DataProtection;
-using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using Microsoft.Owin;
 using Microsoft.Owin.BuilderProperties;
@@ -26,28 +25,17 @@ public OAuthValidationMiddleware(
             }
 
             if (options.DataProtectionProvider == null) {
-                // Create a new DI container and register
-                // the data protection services.
-                var services = new ServiceCollection();
+                // Try to use the application name provided by
+                // the OWIN host as the application discriminator.
+                var discriminator = new AppProperties(app.Properties).AppName;
 
-                services.AddDataProtection(configuration => {
-                    // Try to use the application name provided by
-                    // the OWIN host as the application discriminator.
-                    var discriminator = new AppProperties(app.Properties).AppName;
+                // When an application discriminator cannot be resolved from
+                // the OWIN host properties, generate a temporary identifier.
+                if (string.IsNullOrEmpty(discriminator)) {
+                    discriminator = Guid.NewGuid().ToString();
+                }
 
-                    // When an application discriminator cannot be resolved from
-                    // the OWIN host properties, generate a temporary identifier.
-                    if (string.IsNullOrEmpty(discriminator)) {
-                        discriminator = Guid.NewGuid().ToString();
-                    }
-
-                    configuration.ApplicationDiscriminator = discriminator;
-                });
-
-                var container = services.BuildServiceProvider();
-
-                // Resolve a data protection provider from the services container.
-                options.DataProtectionProvider = container.GetRequiredService<IDataProtectionProvider>();
+                options.DataProtectionProvider = DataProtectionProvider.Create(discriminator);
             }
 
             if (options.AccessTokenFormat == null) {