Odnoklassniki provider: Comments for options, code cleanup.

Author: dyzy

src/AspNet.Security.OAuth.Odnoklassniki/OdnoklassnikiAuthenticationDefaults.cs

@@ -48,6 +48,5 @@ public static class OdnoklassnikiAuthenticationDefaults
         /// Default value for <see cref="OAuthOptions.UserInformationEndpoint"/>.
         /// </summary>
         public const string UserInformationEndpoint = "https://api.ok.ru/fb.do";
-
     }
 }

src/AspNet.Security.OAuth.Odnoklassniki/OdnoklassnikiAuthenticationExtensions.cs

@@ -32,7 +32,7 @@ public static AuthenticationBuilder AddOdnoklassniki([NotNull] this Authenticati
         /// <see cref="AuthenticationBuilder"/>, which enables Odnoklassniki authentication capabilities.
         /// </summary>
         /// <param name="builder">The authentication builder.</param>
-        /// <param name="configuration">The delegate used to configure the OpenID 2.0 options.</param>
+        /// <param name="configuration">The delegate used to configure the OAuth 2.0 options.</param>
         /// <returns>The <see cref="AuthenticationBuilder"/>.</returns>
         public static AuthenticationBuilder AddOdnoklassniki(
             [NotNull] this AuthenticationBuilder builder,

src/AspNet.Security.OAuth.Odnoklassniki/OdnoklassnikiAuthenticationHandler.cs

@@ -5,7 +5,7 @@
  */
 
 using System.Collections.Generic;
-using System.Linq;
+using System.Globalization;
 using System.Net.Http;
 using System.Net.Http.Headers;
 using System.Security.Claims;
@@ -38,10 +38,10 @@ protected override async Task<AuthenticationTicket> CreateTicketAsync([NotNull]
             [NotNull] AuthenticationProperties properties, [NotNull] OAuthTokenResponse tokens)
         {
             string sign;
-            using (var md5Hash = MD5.Create())
+            using (var algorithm = MD5.Create())
             {
-                var accessSecret = GetMd5Hash(md5Hash, tokens.AccessToken + Options.ClientSecret);
-                sign = GetMd5Hash(md5Hash,$"application_key={Options.PublicSecret}format=jsonmethod=users.getCurrentUser{accessSecret}");
+                var accessSecret = GetMd5Hash(algorithm, tokens.AccessToken + Options.ClientSecret);
+                sign = GetMd5Hash(algorithm, $"application_key={Options.PublicSecret}format=jsonmethod=users.getCurrentUser{accessSecret}");
             }
 
             var address = QueryHelpers.AddQueryString(Options.UserInformationEndpoint, new Dictionary<string, string>
@@ -82,7 +82,7 @@ private static string GetMd5Hash(HashAlgorithm hashAlgorithm, string input)
         {
             var sBuilder = new StringBuilder();
             foreach (var t in hashAlgorithm.ComputeHash(Encoding.UTF8.GetBytes(input)))
-                sBuilder.Append(t.ToString("x2"));
+                sBuilder.Append(t.ToString("x2", CultureInfo.InvariantCulture));
             return sBuilder.ToString();
         }
     }

src/AspNet.Security.OAuth.Odnoklassniki/OdnoklassnikiAuthenticationOptions.cs

@@ -7,23 +7,26 @@
 using System.Security.Claims;
 using Microsoft.AspNetCore.Authentication;
 using Microsoft.AspNetCore.Authentication.OAuth;
-using Microsoft.AspNetCore.Http;
 using static AspNet.Security.OAuth.Odnoklassniki.OdnoklassnikiAuthenticationConstants;
 
 namespace AspNet.Security.OAuth.Odnoklassniki
 {
     /// <summary>
     /// Defines a set of options used by <see cref="OdnoklassnikiAuthenticationHandler"/>.
+    /// App registration could be performed by using next instruction: https://apiok.ru/dev/app/create.
+    /// After registration you will receive email with 3 parameters:
+    /// 1. Application ID - mapped to ClientId
+    /// 2. Public App key - mapped to PublicSecret
+    /// 3. Secret App key - mapped to ClientSecret
+    /// Email retrieval requires request to provider on [email protected] for GET_EMAIL permission (https://apiok.ru/ext/oauth/permissions).
     /// </summary>
     public class OdnoklassnikiAuthenticationOptions : OAuthOptions
     {
-        public string PublicSecret { get; set; }
-
         public OdnoklassnikiAuthenticationOptions()
         {
             ClaimsIssuer = OdnoklassnikiAuthenticationDefaults.Issuer;
 
-            CallbackPath = new PathString(OdnoklassnikiAuthenticationDefaults.CallbackPath);
+            CallbackPath = OdnoklassnikiAuthenticationDefaults.CallbackPath;
 
             AuthorizationEndpoint = OdnoklassnikiAuthenticationDefaults.AuthorizationEndpoint;
             TokenEndpoint = OdnoklassnikiAuthenticationDefaults.TokenEndpoint;
@@ -40,5 +43,9 @@ public OdnoklassnikiAuthenticationOptions()
             ClaimActions.MapJsonKey(Claims.ImageUrl, "pic_2");
         }
 
+        /// <summary>
+        /// Public App Key from application registration email.
+        /// </summary>
+        public string PublicSecret { get; set; }
     }
 }