Adhere to the ASP.NET team coding style guidelines

Author: kevinchalet

README.md

@@ -12,10 +12,13 @@ AspNet.Security.OAuth.Providers
 
 **Adding social authentication to your application is a breeze** and just requires a few lines in your `Startup` class:
 
-    app.UseGitHubAuthentication(options => {
-        options.ClientId = "49e302895d8b09ea5656";
-        options.ClientSecret = "98f1bf028608901e9df91d64ee61536fe562064b";
-    });
+```csharp
+app.UseGitHubAuthentication(options =>
+{
+    options.ClientId = "49e302895d8b09ea5656";
+    options.ClientSecret = "98f1bf028608901e9df91d64ee61536fe562064b";
+});
+```
 
 See [https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/tree/dev/samples/Mvc.Client](https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers/tree/dev/samples/Mvc.Client) for a complete sample **using ASP.NET Core MVC and supporting multiple social providers**.
 

samples/Mvc.Client/Controllers/AuthenticationController.cs

@@ -9,20 +9,25 @@
 using Microsoft.AspNetCore.Mvc;
 using Mvc.Client.Extensions;
 
-namespace Mvc.Client.Controllers {
-    public class AuthenticationController : Controller {
+namespace Mvc.Client.Controllers
+{
+    public class AuthenticationController : Controller
+    {
         [HttpGet("~/signin")]
         public IActionResult SignIn() => View("SignIn", HttpContext.GetExternalProviders());
 
         [HttpPost("~/signin")]
-        public IActionResult SignIn([FromForm] string provider) {
+        public IActionResult SignIn([FromForm] string provider)
+        {
             // Note: the "provider" parameter corresponds to the external
             // authentication provider choosen by the user agent.
-            if (string.IsNullOrWhiteSpace(provider)) {
+            if (string.IsNullOrWhiteSpace(provider))
+            {
                 return BadRequest();
             }
 
-            if (!HttpContext.IsProviderSupported(provider)) {
+            if (!HttpContext.IsProviderSupported(provider))
+            {
                 return BadRequest();
             }
 
@@ -33,7 +38,8 @@ public IActionResult SignIn([FromForm] string provider) {
         }
 
         [HttpGet("~/signout"), HttpPost("~/signout")]
-        public IActionResult SignOut() {
+        public IActionResult SignOut()
+        {
             // Instruct the cookies middleware to delete the local cookie created
             // when the user agent is redirected from the external identity provider
             // after a successful authentication flow (e.g Google or Facebook).

samples/Mvc.Client/Controllers/HomeController.cs

@@ -6,8 +6,10 @@
 
 using Microsoft.AspNetCore.Mvc;
 
-namespace Mvc.Client.Controllers {
-    public class HomeController : Controller {
+namespace Mvc.Client.Controllers
+{
+    public class HomeController : Controller
+    {
         [HttpGet("~/")]
         public ActionResult Index() => View();
     }

samples/Mvc.Client/Extensions/HttpContextExtensions.cs

@@ -10,10 +10,14 @@
 using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Http.Authentication;
 
-namespace Mvc.Client.Extensions {
-    public static class HttpContextExtensions {
-        public static IEnumerable<AuthenticationDescription> GetExternalProviders(this HttpContext context) {
-            if (context == null) {
+namespace Mvc.Client.Extensions
+{
+    public static class HttpContextExtensions
+    {
+        public static IEnumerable<AuthenticationDescription> GetExternalProviders(this HttpContext context)
+        {
+            if (context == null)
+            {
                 throw new ArgumentNullException(nameof(context));
             }
 
@@ -22,8 +26,10 @@ public static IEnumerable<AuthenticationDescription> GetExternalProviders(this H
                    select description;
         }
 
-        public static bool IsProviderSupported(this HttpContext context, string provider) {
-            if (context == null) {
+        public static bool IsProviderSupported(this HttpContext context, string provider)
+        {
+            if (context == null)
+            {
                 throw new ArgumentNullException(nameof(context));
             }
 

samples/Mvc.Client/Program.cs

@@ -2,9 +2,12 @@
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
 
-namespace Mvc.Client {
-    public static class Program {
-        public static void Main(string[] args) {
+namespace Mvc.Client
+{
+    public static class Program
+    {
+        public static void Main(string[] args)
+        {
             var configuration = new ConfigurationBuilder()
                 .AddEnvironmentVariables()
                 .AddCommandLine(args)

samples/Mvc.Client/Startup.cs

@@ -10,37 +10,46 @@
 using Microsoft.AspNetCore.Http;
 using Microsoft.Extensions.DependencyInjection;
 
-namespace Mvc.Client {
-    public class Startup {
-        public void ConfigureServices(IServiceCollection services) {
-            services.AddAuthentication(options => {
+namespace Mvc.Client
+{
+    public class Startup
+    {
+        public void ConfigureServices(IServiceCollection services)
+        {
+            services.AddAuthentication(options =>
+            {
                 options.SignInScheme = CookieAuthenticationDefaults.AuthenticationScheme;
             });
 
             services.AddMvc();
         }
 
-        public void Configure(IApplicationBuilder app) {
+        public void Configure(IApplicationBuilder app)
+        {
             app.UseStaticFiles();
 
-            app.UseCookieAuthentication(new CookieAuthenticationOptions {
+            app.UseCookieAuthentication(new CookieAuthenticationOptions
+            {
                 AutomaticAuthenticate = true,
                 AutomaticChallenge = true,
                 LoginPath = new PathString("/signin"),
                 LogoutPath = new PathString("/signout")
             });
 
-            app.UseGoogleAuthentication(new GoogleOptions {
+            app.UseGoogleAuthentication(new GoogleOptions
+            {
                 ClientId = "560027070069-37ldt4kfuohhu3m495hk2j4pjp92d382.apps.googleusercontent.com",
                 ClientSecret = "n2Q-GEw9RQjzcRbU3qhfTj8f"
             });
 
-            app.UseTwitterAuthentication(new TwitterOptions {
+            app.UseTwitterAuthentication(new TwitterOptions
+            {
                 ConsumerKey = "6XaCTaLbMqfj6ww3zvZ5g",
                 ConsumerSecret = "Il2eFzGIrYhz6BWjYhVXBPQSfZuS4xoHpSSyD9PI"
             });
 
-            app.UseGitHubAuthentication(new GitHubAuthenticationOptions {
+            app.UseGitHubAuthentication(new GitHubAuthenticationOptions
+            {
                 ClientId = "49e302895d8b09ea5656",
                 ClientSecret = "98f1bf028608901e9df91d64ee61536fe562064b",
                 Scope = { "user:email" }

samples/Mvc.Client/web.config

@@ -2,8 +2,8 @@
 <configuration>
   <system.webServer>
     <handlers>
-      <add name="aspNetCore" path="*" verb="*" modules="AspNetCoreModule" resourceType="Unspecified" />
+      <add name="aspNetCore" path="*" verb="*" modules="AspNetCoreModule" resourceType="Unspecified"/>
     </handlers>
-    <aspNetCore processPath="%LAUNCHER_PATH%" arguments="%LAUNCHER_ARGS%" stdoutLogEnabled="false" stdoutLogFile=".\logs\stdout" forwardWindowsAuthToken="false" />
+    <aspNetCore processPath="%LAUNCHER_PATH%" arguments="%LAUNCHER_ARGS%" stdoutLogEnabled="false" stdoutLogFile=".\logs\stdout" forwardWindowsAuthToken="false"/>
   </system.webServer>
 </configuration>

src/AspNet.Security.OAuth.ArcGIS/ArcGISAuthenticationDefaults.cs

@@ -5,13 +5,14 @@
  */
 
 using Microsoft.AspNetCore.Builder;
-using Microsoft.AspNetCore.Authentication.OAuth;
 
-namespace AspNet.Security.OAuth.ArcGIS {
+namespace AspNet.Security.OAuth.ArcGIS
+{
     /// <summary>
     /// Default values used by the ArcGIS authentication middleware.
     /// </summary>
-    public static class ArcGISAuthenticationDefaults {
+    public static class ArcGISAuthenticationDefaults
+    {
         /// <summary>
         /// Default value for <see cref="AuthenticationOptions.AuthenticationScheme"/>.
         /// </summary>

src/AspNet.Security.OAuth.ArcGIS/ArcGISAuthenticationExtensions.cs

@@ -9,26 +9,31 @@
 using JetBrains.Annotations;
 using Microsoft.Extensions.Options;
 
-namespace Microsoft.AspNetCore.Builder {
+namespace Microsoft.AspNetCore.Builder
+{
     /// <summary>
     /// Extension methods to add ArcGIS authentication capabilities to an HTTP application pipeline.
     /// </summary>
-    public static class ArcGISAuthenticationExtensions {
+    public static class ArcGISAuthenticationExtensions
+    {
         /// <summary>
         /// Adds the <see cref="ArcGISAuthenticationMiddleware"/> middleware to the specified
         /// <see cref="IApplicationBuilder"/>, which enables ArcGIS authentication capabilities.
         /// </summary>
         /// <param name="app">The <see cref="IApplicationBuilder"/> to add the middleware to.</param>
-        /// <param name="options">A <see cref="ArcGISAuthenticationOptions"/> that specifies options for the middleware.</param>        
+        /// <param name="options">A <see cref="ArcGISAuthenticationOptions"/> that specifies options for the middleware.</param>
         /// <returns>A reference to this instance after the operation has completed.</returns>
         public static IApplicationBuilder UseArcGISAuthentication(
             [NotNull] this IApplicationBuilder app,
-            [NotNull] ArcGISAuthenticationOptions options) {
-            if (app == null) {
+            [NotNull] ArcGISAuthenticationOptions options)
+        {
+            if (app == null)
+            {
                 throw new ArgumentNullException(nameof(app));
             }
 
-            if (options == null) {
+            if (options == null)
+            {
                 throw new ArgumentNullException(nameof(options));
             }
 
@@ -44,12 +49,15 @@ public static IApplicationBuilder UseArcGISAuthentication(
         /// <returns>A reference to this instance after the operation has completed.</returns>
         public static IApplicationBuilder UseArcGISAuthentication(
             [NotNull] this IApplicationBuilder app,
-            [NotNull] Action<ArcGISAuthenticationOptions> configuration) {
-            if (app == null) {
+            [NotNull] Action<ArcGISAuthenticationOptions> configuration)
+        {
+            if (app == null)
+            {
                 throw new ArgumentNullException(nameof(app));
             }
 
-            if (configuration == null) {
+            if (configuration == null)
+            {
                 throw new ArgumentNullException(nameof(configuration));
             }
 

src/AspNet.Security.OAuth.ArcGIS/ArcGISAuthenticationHandler.cs

@@ -19,30 +19,36 @@
 using Microsoft.Extensions.Logging;
 using Newtonsoft.Json.Linq;
 
-namespace AspNet.Security.OAuth.ArcGIS {
-    public class ArcGISAuthenticationHandler : OAuthHandler<ArcGISAuthenticationOptions> {
+namespace AspNet.Security.OAuth.ArcGIS
+{
+    public class ArcGISAuthenticationHandler : OAuthHandler<ArcGISAuthenticationOptions>
+    {
         public ArcGISAuthenticationHandler([NotNull] HttpClient client)
-            : base(client) {
+            : base(client)
+        {
         }
 
         protected override async Task<AuthenticationTicket> CreateTicketAsync([NotNull] ClaimsIdentity identity,
-            [NotNull] AuthenticationProperties properties, [NotNull] OAuthTokenResponse tokens) {
+            [NotNull] AuthenticationProperties properties, [NotNull] OAuthTokenResponse tokens)
+        {
             // Note: the ArcGIS API doesn't support content negotiation via headers.
-            var address = QueryHelpers.AddQueryString(Options.UserInformationEndpoint, new Dictionary<string, string> {
+            var address = QueryHelpers.AddQueryString(Options.UserInformationEndpoint, new Dictionary<string, string>
+            {
                 ["f"] = "json",
                 ["token"] = tokens.AccessToken
             });
 
             var request = new HttpRequestMessage(HttpMethod.Get, address);
             request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
-                        
-            // Request the token 
+
+            // Request the token
             var response = await Backchannel.SendAsync(request, HttpCompletionOption.ResponseHeadersRead, Context.RequestAborted);
             var payload = JObject.Parse(await response.Content.ReadAsStringAsync());
 
             // Note: error responses always return 200 status codes.
             var error = ArcGISAuthenticationHelper.GetError(payload);
-            if (error != null) {
+            if (error != null)
+            {
                 // See https://developers.arcgis.com/authentication/server-based-user-logins/ for more information
                 Logger.LogError("An error occurred while retrieving the user profile: the remote server " +
                                 "returned a response with the following error code: {Code} {Message}.",