Skip to content

Commit 8ee2f76

Browse files
Resolve logging TODO
Remove TODO comment. Check whether Trace logging is enabled before logging the Apple token response.
1 parent 221bfeb commit 8ee2f76

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

src/AspNet.Security.OAuth.Apple/AppleAuthenticationHandler.cs

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,17 @@ protected override async Task<AuthenticationTicket> CreateTicketAsync(
8282
{
8383
string idToken = tokens.Response.Value<string>("id_token");
8484

85-
// TODO These can probably be removed once Sign In with Apple is finalized
86-
Logger.LogInformation("Creating ticket for Sign In with Apple.");
87-
Logger.LogTrace("Access Token: {AccessToken}", tokens.AccessToken);
88-
Logger.LogTrace("Refresh Token: {RefreshToken}", tokens.RefreshToken);
89-
Logger.LogTrace("Token Type: {TokenType}", tokens.TokenType);
90-
Logger.LogTrace("Expires In: {ExpiresIn}", tokens.ExpiresIn);
91-
Logger.LogTrace("Response: {TokenResponse}", tokens.Response);
92-
Logger.LogTrace("ID Token: {IdToken}", idToken);
85+
Logger.LogInformation("Creating ticket for Sign in with Apple.");
86+
87+
if (Logger.IsEnabled(LogLevel.Trace))
88+
{
89+
Logger.LogTrace("Access Token: {AccessToken}", tokens.AccessToken);
90+
Logger.LogTrace("Refresh Token: {RefreshToken}", tokens.RefreshToken);
91+
Logger.LogTrace("Token Type: {TokenType}", tokens.TokenType);
92+
Logger.LogTrace("Expires In: {ExpiresIn}", tokens.ExpiresIn);
93+
Logger.LogTrace("Response: {TokenResponse}", tokens.Response);
94+
Logger.LogTrace("ID Token: {IdToken}", idToken);
95+
}
9396

9497
if (string.IsNullOrWhiteSpace(idToken))
9598
{

0 commit comments

Comments
 (0)