Make 256-bit more explicit

martincostello · martincostello · commit 9cf06a1de2fe · 2022-01-06T16:52:40.000Z
Use 256/8 instead of 32 to make it clearer why the buffer is the size it is.
diff --git a/src/AspNet.Security.OAuth.Alipay/AlipayAuthenticationHandler.cs b/src/AspNet.Security.OAuth.Alipay/AlipayAuthenticationHandler.cs
@@ -220,7 +220,7 @@ protected override string BuildChallengeUrl([NotNull] AuthenticationProperties p
 
         if (Options.UsePkce)
         {
-            byte[] bytes = RandomNumberGenerator.GetBytes(32);
+            byte[] bytes = RandomNumberGenerator.GetBytes(256 / 8);
             string codeVerifier = WebEncoders.Base64UrlEncode(bytes);
 
             // Store this for use during the code redemption.
diff --git a/src/AspNet.Security.OAuth.Deezer/DeezerAuthenticationHandler.cs b/src/AspNet.Security.OAuth.Deezer/DeezerAuthenticationHandler.cs
@@ -101,7 +101,7 @@ protected override string BuildChallengeUrl([NotNull] AuthenticationProperties p
 
         if (Options.UsePkce)
         {
-            byte[] bytes = RandomNumberGenerator.GetBytes(32);
+            byte[] bytes = RandomNumberGenerator.GetBytes(256 / 8);
             string codeVerifier = WebEncoders.Base64UrlEncode(bytes);
 
             // Store this for use during the code redemption.
diff --git a/src/AspNet.Security.OAuth.Mixcloud/MixcloudAuthenticationHandler.cs b/src/AspNet.Security.OAuth.Mixcloud/MixcloudAuthenticationHandler.cs
@@ -41,7 +41,7 @@ protected override string BuildChallengeUrl([NotNull] AuthenticationProperties p
 
         if (Options.UsePkce)
         {
-            var bytes = RandomNumberGenerator.GetBytes(32);
+            var bytes = RandomNumberGenerator.GetBytes(256 / 8);
             var codeVerifier = WebEncoders.Base64UrlEncode(bytes);
 
             // Store this for use during the code redemption.
diff --git a/src/AspNet.Security.OAuth.Shopify/ShopifyAuthenticationHandler.cs b/src/AspNet.Security.OAuth.Shopify/ShopifyAuthenticationHandler.cs
@@ -118,7 +118,7 @@ protected override string BuildChallengeUrl([NotNull] AuthenticationProperties p
 
         if (Options.UsePkce)
         {
-            byte[] bytes = RandomNumberGenerator.GetBytes(32);
+            byte[] bytes = RandomNumberGenerator.GetBytes(256 / 8);
             string codeVerifier = WebEncoders.Base64UrlEncode(bytes);
 
             // Store this for use during the code redemption.
diff --git a/src/AspNet.Security.OAuth.Weixin/WeixinAuthenticationHandler.cs b/src/AspNet.Security.OAuth.Weixin/WeixinAuthenticationHandler.cs
@@ -138,7 +138,7 @@ protected override string BuildChallengeUrl([NotNull] AuthenticationProperties p
 
         if (Options.UsePkce)
         {
-            var bytes = RandomNumberGenerator.GetBytes(32);
+            var bytes = RandomNumberGenerator.GetBytes(256 / 8);
             var codeVerifier = WebEncoders.Base64UrlEncode(bytes);
 
             // Store this for use during the code redemption.
diff --git a/src/AspNet.Security.OAuth.WorkWeixin/WorkWeixinAuthenticationHandler.cs b/src/AspNet.Security.OAuth.WorkWeixin/WorkWeixinAuthenticationHandler.cs
@@ -111,7 +111,7 @@ protected override string BuildChallengeUrl([NotNull] AuthenticationProperties p
 
         if (Options.UsePkce)
         {
-            var bytes = RandomNumberGenerator.GetBytes(32);
+            var bytes = RandomNumberGenerator.GetBytes(256 / 8);
             var codeVerifier = WebEncoders.Base64UrlEncode(bytes);
 
             // Store this for use during the code redemption.

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ protected override string BuildChallengeUrl([NotNull] AuthenticationProperties p`
`220`	`220`
`221`	`221`	`if (Options.UsePkce)`
`222`	`222`	`{`
`223`		`- byte[] bytes = RandomNumberGenerator.GetBytes(32);`
	`223`	`+ byte[] bytes = RandomNumberGenerator.GetBytes(256 / 8);`
`224`	`224`	`string codeVerifier = WebEncoders.Base64UrlEncode(bytes);`
`225`	`225`
`226`	`226`	`// Store this for use during the code redemption.`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ protected override string BuildChallengeUrl([NotNull] AuthenticationProperties p`
`101`	`101`
`102`	`102`	`if (Options.UsePkce)`
`103`	`103`	`{`
`104`		`- byte[] bytes = RandomNumberGenerator.GetBytes(32);`
	`104`	`+ byte[] bytes = RandomNumberGenerator.GetBytes(256 / 8);`
`105`	`105`	`string codeVerifier = WebEncoders.Base64UrlEncode(bytes);`
`106`	`106`
`107`	`107`	`// Store this for use during the code redemption.`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ protected override string BuildChallengeUrl([NotNull] AuthenticationProperties p`
`41`	`41`
`42`	`42`	`if (Options.UsePkce)`
`43`	`43`	`{`
`44`		`- var bytes = RandomNumberGenerator.GetBytes(32);`
	`44`	`+ var bytes = RandomNumberGenerator.GetBytes(256 / 8);`
`45`	`45`	`var codeVerifier = WebEncoders.Base64UrlEncode(bytes);`
`46`	`46`
`47`	`47`	`// Store this for use during the code redemption.`
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ protected override string BuildChallengeUrl([NotNull] AuthenticationProperties p`
`118`	`118`
`119`	`119`	`if (Options.UsePkce)`
`120`	`120`	`{`
`121`		`- byte[] bytes = RandomNumberGenerator.GetBytes(32);`
	`121`	`+ byte[] bytes = RandomNumberGenerator.GetBytes(256 / 8);`
`122`	`122`	`string codeVerifier = WebEncoders.Base64UrlEncode(bytes);`
`123`	`123`
`124`	`124`	`// Store this for use during the code redemption.`
Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ protected override string BuildChallengeUrl([NotNull] AuthenticationProperties p`
`138`	`138`
`139`	`139`	`if (Options.UsePkce)`
`140`	`140`	`{`
`141`		`- var bytes = RandomNumberGenerator.GetBytes(32);`
	`141`	`+ var bytes = RandomNumberGenerator.GetBytes(256 / 8);`
`142`	`142`	`var codeVerifier = WebEncoders.Base64UrlEncode(bytes);`
`143`	`143`
`144`	`144`	`// Store this for use during the code redemption.`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ protected override string BuildChallengeUrl([NotNull] AuthenticationProperties p`
`111`	`111`
`112`	`112`	`if (Options.UsePkce)`
`113`	`113`	`{`
`114`		`- var bytes = RandomNumberGenerator.GetBytes(32);`
	`114`	`+ var bytes = RandomNumberGenerator.GetBytes(256 / 8);`
`115`	`115`	`var codeVerifier = WebEncoders.Base64UrlEncode(bytes);`
`116`	`116`
`117`	`117`	`// Store this for use during the code redemption.`