Add tests for Apple DI registrations

Add unit tests for service registration for the Apple provider to ensure that existing registrations are not overwritten.

Author: martincostello

Directory.Packages.props

@@ -10,6 +10,7 @@
     <PackageVersion Include="Microsoft.AspNetCore.TestHost" Version="3.1.5" />
     <PackageVersion Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.0.0" />
     <PackageVersion Include="Microsoft.NetCore.Analyzers" Version="3.0.0" />
+    <PackageVersion Include="Moq" Version="4.14.5" />
     <PackageVersion Include="Shouldly" Version="3.0.2" />
     <PackageVersion Include="StyleCop.Analyzers" Version="1.1.118" />
     <PackageVersion Include="System.IdentityModel.Tokens.Jwt" Version="5.5.0" />

test/AspNet.Security.OAuth.Providers.Tests/Apple/AppleAuthenticationOptionsExtensionsTests.cs

@@ -0,0 +1,75 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
+ * See https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers
+ * for more information concerning the license and the contributors participating to this project.
+ */
+
+using System.IdentityModel.Tokens.Jwt;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Options;
+using Microsoft.IdentityModel.Tokens;
+using Moq;
+using Shouldly;
+using Xunit;
+
+namespace AspNet.Security.OAuth.Apple
+{
+    public static class AppleAuthenticationOptionsExtensionsTests
+    {
+        [Fact]
+        public static void AddApple_Registers_Services()
+        {
+            // Arrange
+            var services = new ServiceCollection();
+
+            services.AddLogging()
+                    .AddAuthentication()
+                    .AddApple();
+
+            // Act
+            using var serviceProvider = services.BuildServiceProvider();
+
+            // Assert
+            serviceProvider.GetRequiredService<AppleAuthenticationHandler>().ShouldNotBeNull();
+            serviceProvider.GetRequiredService<AppleClientSecretGenerator>().ShouldNotBeNull();
+            serviceProvider.GetRequiredService<AppleIdTokenValidator>().ShouldNotBeNull();
+            serviceProvider.GetRequiredService<AppleKeyStore>().ShouldNotBeNull();
+            serviceProvider.GetRequiredService<IOptions<AppleAuthenticationOptions>>().ShouldNotBeNull();
+        }
+
+        [Fact]
+        public static void AddApple_Does_Not_Overwrite_Existing_Service_Registrations()
+        {
+            // Arrange
+            var cryptoProviderFactory = Mock.Of<CryptoProviderFactory>();
+            var keyStore = Mock.Of<AppleKeyStore>();
+            var secretGenerator = Mock.Of<AppleClientSecretGenerator>();
+            var tokenHandler = Mock.Of<JwtSecurityTokenHandler>();
+            var tokenValidator = Mock.Of<AppleIdTokenValidator>();
+
+            var services = new ServiceCollection()
+                .AddSingleton(cryptoProviderFactory)
+                .AddSingleton(keyStore)
+                .AddSingleton(secretGenerator)
+                .AddSingleton(tokenHandler)
+                .AddSingleton(tokenValidator);
+
+            services.AddLogging()
+                    .AddAuthentication()
+                    .AddApple();
+
+            // Act
+            using var serviceProvider = services.BuildServiceProvider();
+
+            // Assert
+            serviceProvider.GetRequiredService<AppleAuthenticationHandler>().ShouldNotBeNull();
+            serviceProvider.GetRequiredService<IOptions<AppleAuthenticationOptions>>().ShouldNotBeNull();
+
+            serviceProvider.GetRequiredService<AppleClientSecretGenerator>().ShouldBeSameAs(secretGenerator);
+            serviceProvider.GetRequiredService<AppleIdTokenValidator>().ShouldBeSameAs(tokenValidator);
+            serviceProvider.GetRequiredService<AppleKeyStore>().ShouldBeSameAs(keyStore);
+            serviceProvider.GetRequiredService<CryptoProviderFactory>().ShouldBeSameAs(cryptoProviderFactory);
+            serviceProvider.GetRequiredService<JwtSecurityTokenHandler>().ShouldBeSameAs(tokenHandler);
+        }
+    }
+}

test/AspNet.Security.OAuth.Providers.Tests/AspNet.Security.OAuth.Providers.Tests.csproj

@@ -22,10 +22,12 @@
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="JetBrains.Annotations" PrivateAssets="All" />
     <PackageReference Include="JustEat.HttpClientInterception" />
     <PackageReference Include="MartinCostello.Logging.XUnit" />
     <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" />
     <PackageReference Include="Microsoft.AspNetCore.TestHost" />
+    <PackageReference Include="Moq" />
     <PackageReference Include="Shouldly" />
   </ItemGroup>